Skip to content

Commit

Permalink
Clarify running unit tests documentation
Browse files Browse the repository at this point in the history
Clarify that the test target must be built before attempting to run the
unit tests themsleves. The previous instruction only followed the chrome
build instructions. It was not immediately obvious that build chrome
would not also generate the unit_tests binary.

Change-Id: I2894d40926d6546a929ccfcdff4b08bc8f87f9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3428904
Reviewed-by: Roman Arora <romanarora@google.com>
Commit-Queue: Fred Shih <ffred@google.com>
Cr-Commit-Position: refs/heads/main@{#966576}
  • Loading branch information
ffredsh authored and Chromium LUCI CQ committed Feb 3, 2022
1 parent 84ed1c1 commit 865fb8f
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions docs/linux/build_instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,14 @@ $ out/Default/chrome

## Running test targets

You can run the tests in the same way. You can also limit which tests are
run using the `--gtest_filter` arg, e.g.:
First build the unit_tests binary by running the command:

```shell
$ autoninja -C out/Default unit_tests
```

You can run the tests by running the unit_tests binary. You can also limit which
tests are run using the `--gtest_filter` arg, e.g.:

```shell
$ out/Default/unit_tests --gtest_filter="PushClientTest.*"
Expand Down

0 comments on commit 865fb8f

Please sign in to comment.