Skip to content

Commit

Permalink
content: Replace uses of BrowserThread task posting with post_task.h API
Browse files Browse the repository at this point in the history
This patch updates callsites of BrowserThread task posting methods to
use the post_task.h API instead.

Background: We're changing the way tasks are posted to a BrowserThread,
see PSA [1] and design doc [2]. This unifies the way tasks are posted
and paves the way for annotating tasks with task types and other
attributes that can be used to prioritize tasks in the future browser
UI thread scheduler (design doc [3]).

This CL changes callsites of the following forms:
(a) BrowserThread::Post*Task(BrowserThread::UI/IO, ..) to
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI/IO}, ..),
(b) BrowserThread::GetTaskRunnerForThread(BrowserThread::UI/IO) to
    base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::UI/IO}).

It also adds necessary includes. These mechanical changes were applied
by a script.

Tasks posted with the same BrowserThread::ID trait (via
PostTaskWithTraits or TaskRunners obtained from
Create*TaskRunnerWithTraits) will still execute in the order they
were posted, see [4].

[1] https://groups.google.com/a/chromium.org/d/topic/chromium-dev/A3_snMVXv8A/discussion
[2] https://docs.google.com/document/d/1SGy9VTXUwyXEX_yBZ0ukFAnS8B0hDeMUJD-1iALaE-Q/edit?usp=sharing
[3] https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit?usp=sharing
[4] https://cs.chromium.org/chromium/src/base/task/post_task.h?l=66

TBR=achuith@chromium.org, afakhry@chromium.org, agl@chromium.org, avi@chromium.org, bbudge@chromium.org, bengr@chromium.org, benwells@chromium.org, bnc@chromium.org, calamity@chromium.org, ccameron@chromium.org, chiniforooshan@chromium.org, cjgrant@chromium.org, cmumford@chromium.org, csharrison@chromium.org, dalecurtis@chromium.org, delphick@chromium.org, dgozman@chromium.org, dmazzoni@chromium.org, droger@chromium.org, dschuff@chromium.org, dullweber@chromium.org, erikchen@chromium.org, felt@chromium.org, fgorski@chromium.org, gogerald@chromium.org, groby@chromium.org, horo@chromium.org, imcheng@chromium.org, jcivelli@chromium.org, jianli@chromium.org, jinho.bang@samsung.com, jkarlin@chromium.org, jochen@chromium.org, kinuko@chromium.org, lazyboy@chromium.org, lpy@chromium.org, markusheintz@chromium.org, mattcary@chromium.org, maxmorin@chromium.org, miu@chromium.org, mkwst@chromium.org, mmenke@chromium.org, mpearson@chromium.org, msramek@chromium.org, nick@chromium.org, nparker@chromium.org, nyquist@chromium.org, peter@chromium.org, pwnall@chromium.org, qinmin@chromium.org, rbpotter@chromium.org, rdevlin.cronin@chromium.org, rouslan@chromium.org, scottmg@chromium.org, servolk@chromium.org, skuhne@chromium.org, sky@chromium.org, tapted@chromium.org, tbansal@chromium.org, thestig@chromium.org, tommi@chromium.org, tommycli@chromium.org, torne@chromium.org, tschumann@chromium.org, vabr@chromium.org, vakh@chromium.org, waffles@chromium.org, yfriedman@chromium.org, zmo@chromium.org, bartfab@chromium.org

Bug: 878356
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I37526c8e75630ee7bec29421276094a30e903894
Reviewed-on: https://chromium-review.googlesource.com/1186623
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592750}
  • Loading branch information
betasheet authored and Commit Bot committed Sep 20, 2018
1 parent 860a3b3 commit 8652dcd
Show file tree
Hide file tree
Showing 936 changed files with 6,758 additions and 5,205 deletions.
5 changes: 3 additions & 2 deletions android_webview/browser/aw_browser_context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "components/url_formatter/url_fixer.h"
#include "components/user_prefs/user_prefs.h"
#include "components/visitedlink/browser/visitedlink_master.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/ssl_host_state_delegate.h"
#include "content/public/browser/storage_partition.h"
Expand Down Expand Up @@ -66,7 +67,7 @@ AwBrowserContext* g_browser_context = NULL;
std::unique_ptr<net::ProxyConfigServiceAndroid> CreateProxyConfigService() {
std::unique_ptr<net::ProxyConfigServiceAndroid> config_service_android =
std::make_unique<net::ProxyConfigServiceAndroid>(
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO}),
base::ThreadTaskRunnerHandle::Get());

// TODO(csharrison) Architect the wrapper better so we don't need a cast for
Expand All @@ -82,7 +83,7 @@ CreateSafeBrowsingWhitelistManager() {
base::CreateSequencedTaskRunnerWithTraits(
{base::MayBlock(), base::TaskPriority::BEST_EFFORT});
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner =
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO});
return std::make_unique<AwSafeBrowsingWhitelistManager>(
background_task_runner, io_task_runner);
}
Expand Down
5 changes: 3 additions & 2 deletions android_webview/browser/aw_browser_terminator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include "base/sync_socket.h"
#include "base/task/post_task.h"
#include "components/crash/content/browser/crash_dump_manager_android.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/child_process_data.h"
#include "content/public/browser/child_process_launcher_utils.h"
Expand Down Expand Up @@ -153,8 +154,8 @@ void AwBrowserTerminator::OnChildExitAsync(
crashed = true;
}

BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&OnRenderProcessGoneDetail, info.process_host_id, info.pid,
crashed));
}
Expand Down
6 changes: 4 additions & 2 deletions android_webview/browser/aw_content_browser_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/post_task.h"
#include "components/autofill/content/browser/content_autofill_driver_factory.h"
#include "components/cdm/browser/cdm_message_filter_android.h"
#include "components/crash/content/browser/child_exit_observer_android.h"
Expand All @@ -53,6 +54,7 @@
#include "components/services/heap_profiling/public/mojom/constants.mojom.h"
#include "components/spellcheck/spellcheck_buildflags.h"
#include "content/public/browser/browser_message_filter.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/child_process_security_policy.h"
#include "content/public/browser/client_certificate_delegate.h"
Expand Down Expand Up @@ -605,12 +607,12 @@ void AwContentBrowserClient::ExposeInterfacesToRenderer(
base::BindRepeating(
&AwContentBrowserClient::GetSafeBrowsingUrlCheckerDelegate,
base::Unretained(this))),
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO));
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO}));
}
#if BUILDFLAG(ENABLE_SPELLCHECK)
registry->AddInterface(
base::BindRepeating(&SpellCheckHostImpl::Create),
BrowserThread::GetTaskRunnerForThread(BrowserThread::UI));
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::UI}));
#endif
}

Expand Down
8 changes: 5 additions & 3 deletions android_webview/browser/aw_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
#include "base/single_thread_task_runner.h"
#include "base/strings/string16.h"
#include "base/supports_user_data.h"
#include "base/task/post_task.h"
#include "base/threading/thread_restrictions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/autofill/android/autofill_provider_android.h"
Expand All @@ -63,6 +64,7 @@
#include "components/navigation_interception/intercept_navigation_delegate.h"
#include "content/public/browser/android/child_process_importance.h"
#include "content/public/browser/android/synchronous_compositor.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/browsing_data_remover.h"
#include "content/public/browser/child_process_security_policy.h"
Expand Down Expand Up @@ -235,7 +237,7 @@ AwContents::AwContents(std::unique_ptr<WebContents> web_contents)
functor_(nullptr),
browser_view_renderer_(
this,
BrowserThread::GetTaskRunnerForThread(BrowserThread::UI)),
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::UI})),
web_contents_(std::move(web_contents)),
renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()) {
base::subtle::NoBarrier_AtomicIncrement(&g_instance_count, 1);
Expand Down Expand Up @@ -586,8 +588,8 @@ void ShowGeolocationPromptHelper(const JavaObjectWeakGlobalRef& java_ref,
const GURL& origin) {
JNIEnv* env = AttachCurrentThread();
if (java_ref.get(env).obj()) {
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(&ShowGeolocationPromptHelperTask, java_ref, origin));
}
}
Expand Down
6 changes: 4 additions & 2 deletions android_webview/browser/aw_contents_statics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
#include "base/android/jni_string.h"
#include "base/android/scoped_java_ref.h"
#include "base/callback.h"
#include "base/task/post_task.h"
#include "components/google/core/common/google_util.h"
#include "components/security_interstitials/core/urls.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/common/url_constants.h"
Expand Down Expand Up @@ -73,8 +75,8 @@ void JNI_AwContentsStatics_ClearClientCertPreferences(
const JavaParamRef<jclass>&,
const JavaParamRef<jobject>& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,
base::PostTaskWithTraitsAndReply(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&NotifyClientCertificatesChanged),
base::BindOnce(&ClientCertificatesCleared,
ScopedJavaGlobalRef<jobject>(env, callback)));
Expand Down
4 changes: 3 additions & 1 deletion android_webview/browser/aw_gl_functor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#include "android_webview/browser/aw_gl_functor.h"

#include "android_webview/public/browser/draw_gl.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "jni/AwGLFunctor_jni.h"

Expand Down Expand Up @@ -35,7 +37,7 @@ AwGLFunctor::AwGLFunctor(const JavaObjectWeakGlobalRef& java_ref)
: java_ref_(java_ref),
render_thread_manager_(
this,
BrowserThread::GetTaskRunnerForThread(BrowserThread::UI)) {
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::UI})) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
++g_instance_count;
}
Expand Down
20 changes: 11 additions & 9 deletions android_webview/browser/aw_login_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
#include "base/android/jni_android.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
Expand All @@ -28,8 +30,8 @@ scoped_refptr<AwLoginDelegate> AwLoginDelegate::Create(
LoginAuthRequiredCallback auth_required_callback) {
scoped_refptr<AwLoginDelegate> instance(
new AwLoginDelegate(auth_info, std::move(auth_required_callback)));
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&AwLoginDelegate::HandleHttpAuthRequestOnUIThread,
instance, first_auth_attempt, web_contents_getter));
return instance;
Expand All @@ -50,15 +52,15 @@ AwLoginDelegate::~AwLoginDelegate() {
void AwLoginDelegate::Proceed(const base::string16& user,
const base::string16& password) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
base::BindOnce(&AwLoginDelegate::ProceedOnIOThread,
this, user, password));
base::PostTaskWithTraits(FROM_HERE, {BrowserThread::IO},
base::BindOnce(&AwLoginDelegate::ProceedOnIOThread,
this, user, password));
}

void AwLoginDelegate::Cancel() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&AwLoginDelegate::CancelOnIOThread, this));
}

Expand Down Expand Up @@ -102,8 +104,8 @@ void AwLoginDelegate::OnRequestCancelled() {

void AwLoginDelegate::DeleteAuthHandlerSoon() {
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&AwLoginDelegate::DeleteAuthHandlerSoon, this));
return;
}
Expand Down
21 changes: 12 additions & 9 deletions android_webview/browser/aw_quota_manager_bridge.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include "base/android/jni_string.h"
#include "base/memory/scoped_refptr.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/common/content_client.h"
Expand Down Expand Up @@ -82,8 +84,8 @@ GetOriginsTask::~GetOriginsTask() {}

void GetOriginsTask::Run() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(&QuotaManager::GetOriginsModifiedSince, quota_manager_,
blink::mojom::StorageType::kTemporary,
base::Time() /* Since beginning of time. */,
Expand Down Expand Up @@ -126,8 +128,8 @@ void GetOriginsTask::OnUsageAndQuotaObtained(
void GetOriginsTask::CheckDone() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (num_callbacks_received_ == num_callbacks_to_wait_) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&GetOriginsTask::DoneOnUIThread, this));
} else if (num_callbacks_received_ > num_callbacks_to_wait_) {
NOTREACHED();
Expand All @@ -144,7 +146,7 @@ void RunOnUIThread(base::OnceClosure task) {
if (BrowserThread::CurrentlyOn(BrowserThread::UI)) {
std::move(task).Run();
} else {
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, std::move(task));
base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI}, std::move(task));
}
}

Expand Down Expand Up @@ -286,8 +288,9 @@ void OnUsageAndQuotaObtained(
usage = 0;
quota = 0;
}
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
base::BindOnce(std::move(ui_callback), usage, quota));
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(std::move(ui_callback), usage, quota));
}

} // namespace
Expand All @@ -314,8 +317,8 @@ void AwQuotaManagerBridge::GetUsageAndQuotaForOriginOnUiThread(
base::BindOnce(&AwQuotaManagerBridge::QuotaUsageCallbackImpl,
weak_factory_.GetWeakPtr(), callback_id, is_quota);

BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::IO},
base::BindOnce(
&QuotaManager::GetUsageAndQuota, GetQuotaManager(), GURL(origin),
blink::mojom::StorageType::kTemporary,
Expand Down
6 changes: 4 additions & 2 deletions android_webview/browser/aw_safe_browsing_ui_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
#include "base/command_line.h"
#include "base/metrics/histogram_macros.h"
#include "base/path_service.h"
#include "base/task/post_task.h"
#include "components/prefs/pref_service.h"
#include "components/safe_browsing/base_ui_manager.h"
#include "components/safe_browsing/browser/safe_browsing_network_context.h"
#include "components/safe_browsing/browser/safe_browsing_url_request_context_getter.h"
#include "components/safe_browsing/common/safebrowsing_constants.h"
#include "components/safe_browsing/db/v4_protocol_manager_util.h"
#include "components/safe_browsing/ping_manager.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "services/network/public/cpp/features.h"
#include "services/network/public/mojom/network_service.mojom.h"
Expand Down Expand Up @@ -105,8 +107,8 @@ scoped_refptr<network::SharedURLLoaderFactory>
AwSafeBrowsingUIManager::GetURLLoaderFactoryOnIOThread() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!shared_url_loader_factory_on_io_) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&AwSafeBrowsingUIManager::CreateURLLoaderFactoryForIO,
this, MakeRequest(&url_loader_factory_on_io_)));
shared_url_loader_factory_on_io_ =
Expand Down
14 changes: 8 additions & 6 deletions android_webview/browser/aw_url_checker_delegate_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@
#include "android_webview/browser/aw_safe_browsing_whitelist_manager.h"
#include "android_webview/browser/net/aw_web_resource_request.h"
#include "base/bind.h"
#include "base/task/post_task.h"
#include "components/safe_browsing/db/database_manager.h"
#include "components/safe_browsing/db/v4_protocol_manager_util.h"
#include "components/security_interstitials/content/unsafe_resource.h"
#include "components/security_interstitials/core/urls.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
Expand Down Expand Up @@ -46,8 +48,8 @@ void AwUrlCheckerDelegateImpl::StartDisplayingBlockingPageHelper(
AwWebResourceRequest request(resource.url.spec(), method, is_main_frame,
has_user_gesture, headers);

content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(&AwUrlCheckerDelegateImpl::StartApplicationResponse,
ui_manager_, resource, std::move(request)));
}
Expand Down Expand Up @@ -128,8 +130,8 @@ void AwUrlCheckerDelegateImpl::DoApplicationResponse(
bool proceed;
switch (action) {
case SafeBrowsingAction::SHOW_INTERSTITIAL:
content::BrowserThread::PostTask(
content::BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(
&AwUrlCheckerDelegateImpl::StartDisplayingDefaultBlockingPage,
ui_manager, resource));
Expand Down Expand Up @@ -175,8 +177,8 @@ void AwUrlCheckerDelegateImpl::StartDisplayingDefaultBlockingPage(
}

// Reporting back that it is not okay to proceed with loading the URL.
content::BrowserThread::PostTask(content::BrowserThread::IO, FROM_HERE,
base::BindOnce(resource.callback, false));
base::PostTaskWithTraits(FROM_HERE, {content::BrowserThread::IO},
base::BindOnce(resource.callback, false));
}

} // namespace android_webview
6 changes: 4 additions & 2 deletions android_webview/browser/net/aw_network_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
#include "android_webview/browser/aw_cookie_access_policy.h"
#include "android_webview/browser/net/aw_web_resource_request.h"
#include "base/android/build_info.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/resource_request_info.h"
#include "net/base/completion_once_callback.h"
Expand Down Expand Up @@ -79,8 +81,8 @@ int AwNetworkDelegate::OnHeadersReceived(
std::unique_ptr<AwContentsClientBridge::HttpErrorInfo> error_info =
AwContentsClientBridge::ExtractHttpErrorInfo(original_response_headers);

BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::PostTaskWithTraits(
FROM_HERE, {BrowserThread::UI},
base::BindOnce(&OnReceivedHttpErrorOnUiThread,
request_info->GetWebContentsGetterForRequest(),
AwWebResourceRequest(*request), std::move(error_info)));
Expand Down
5 changes: 3 additions & 2 deletions android_webview/browser/net/aw_url_request_context_getter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service.h"
#include "components/version_info/version_info.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/cookie_store_factory.h"
Expand Down Expand Up @@ -194,7 +195,7 @@ AwURLRequestContextGetter::AwURLRequestContextGetter(
DCHECK_CURRENTLY_ON(BrowserThread::UI);

scoped_refptr<base::SingleThreadTaskRunner> io_thread_proxy =
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO});

auth_server_whitelist_.Init(
prefs::kAuthServerWhitelist, user_pref_service,
Expand Down Expand Up @@ -370,7 +371,7 @@ net::URLRequestContext* AwURLRequestContextGetter::GetURLRequestContext() {

scoped_refptr<base::SingleThreadTaskRunner>
AwURLRequestContextGetter::GetNetworkTaskRunner() const {
return BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
return base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO});
}

void AwURLRequestContextGetter::SetHandlersAndInterceptors(
Expand Down
Loading

0 comments on commit 8652dcd

Please sign in to comment.