Skip to content

Commit

Permalink
Update docs/ to Gerrit-style git footers
Browse files Browse the repository at this point in the history
Replace TBR= with Tbr:, BUG= with Bug:, TEST= with Test:, NOTRY= with
No-Try: and CC= with CC:.

Most of the footers are available here:
https://www.chromium.org/developers/contributing-code/-bug-syntax.

Bug: None
Change-Id: I79ad7cd84ceac8a1f5a08b9e87f1581c0efb31ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089477
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#747851}
  • Loading branch information
hferreiro authored and Commit Bot committed Mar 6, 2020
1 parent dd01376 commit 804beaf
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions docs/accessibility/brltty.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ To upload a change, use repo, something like this:
```
repo start <branch_name> .
git commit -a
BUG=chromium:12345
TEST=Write what you tested here
Bug:chromium:12345
Test:Write what you tested here
repo upload .
```

Expand Down
6 changes: 3 additions & 3 deletions docs/accessibility/espeak.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,10 @@ cros deploy CHROMEBOOK_IP_ADDRESS espeak-ng

To upload the change for review, use 'repo start' to start making changes
in this package, then commit the change to git, ensuring that you're
changing both the ebuild and manifest file and adding appropriate BUG=
and TEST= lines, then use 'repo upload' to upload the change for review.
changing both the ebuild and manifest file and adding appropriate Bug:
and Test: lines, then use 'repo upload' to upload the change for review.

## Running on Chrome OS on Desktop Linux

See [Chromevox on Desktop Linux](chromevox_on_desktop_linux.md#speech) for more
how to use eSpeak's speech engine on Chrome OS emulated on desktop Linux.
how to use eSpeak's speech engine on Chrome OS emulated on desktop Linux.
4 changes: 2 additions & 2 deletions docs/accessibility/patts.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ To upload the change, use repo upload, something like this:

```
git commit -a
BUG=chromium:12345
TEST=Write what you tested here
Bug:chromium:12345
Test:Write what you tested here
repo upload .
```

Expand Down
4 changes: 2 additions & 2 deletions docs/code_reviews.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ Otherwise the reviewer won't know to review the patch.
* Add the reviewer's email address in the code review tool's reviewer field
like normal.

* Add a line "TBR=<reviewer's email>" to the bottom of the change list
description. e.g. `TBR=reviewer1@chromium.org,reviewer2@chromium.org`
* Add a line "Tbr:<reviewer's email>" to the bottom of the change list
description. e.g. `Tbr:reviewer1@chromium.org,reviewer2@chromium.org`

* Type a message so that the owners in the TBR list can understand who is
responsible for reviewing what, as part of their post-commit review
Expand Down
2 changes: 1 addition & 1 deletion docs/gpu/pixel_wrangling.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ shift, and a calendar appointment.
GPU bots.
* In this case you'll upload CLs to Gerrit to perform reverts (optionally
using the new "Revert" button in the UI), and might consider using
`TBR=` to speed through trivial and urgent CLs. In general, try to send
`Tbr:` to speed through trivial and urgent CLs. In general, try to send
all CLs through the commit queue.
* Contact bajones, kainino, kbr, vmiura, zmo, or another member of the
Chrome GPU team who's already a committer for help landing patches or
Expand Down
10 changes: 5 additions & 5 deletions docs/speed/bot_health_sheriffing/how_to_disable_a_story.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ whereas an entry disabling a benchmark on an entire platform might look like:

Once you've committed your changes locally, your CL can be submitted with:

- `NOTRY=true`
- `TBR=`someone from [`tools/perf/OWNERS`](https://cs.chromium.org/chromium/src/tools/perf/OWNERS?q=tools/perf/owners&sq=package:chromium&dr)
- `CC=`benchmark owner found in [this spreadsheet](https://docs.google.com/spreadsheets/u/1/d/1xaAo0_SU3iDfGdqDJZX_jRV0QtkufwHUKH3kQKF3YQs/edit#gid=0)
- `BUG=`tracking bug
- `No-Try:True`
- `Tbr:`someone from [`tools/perf/OWNERS`](https://cs.chromium.org/chromium/src/tools/perf/OWNERS?q=tools/perf/owners&sq=package:chromium&dr)
- `CC:`benchmark owner found in [this spreadsheet](https://docs.google.com/spreadsheets/u/1/d/1xaAo0_SU3iDfGdqDJZX_jRV0QtkufwHUKH3kQKF3YQs/edit#gid=0)
- `Bug:`tracking bug

*Please make sure to CC the benchmark owner so that they're aware that they've lost coverage.*

The `TBR` and `NOTRY` are permitted and recommended so long as the only file changed is `tools/perf/expectations.config`. If your change touches real code rather than just that configuration data, you'll need a real review before submitting it.
The `Tbr:` and `No-Try:` are permitted and recommended so long as the only file changed is `tools/perf/expectations.config`. If your change touches real code rather than just that configuration data, you'll need a real review before submitting it.

# How to disable a failing gtest perf test

Expand Down
2 changes: 1 addition & 1 deletion docs/updating_clang_format_binaries.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ The `README.chromium` file ought to be updated with version and date info.

The binaries were built at clang revision ####### on ####DATETIME####.

BUG=
Bug:

The change should **always** include new `.sha1` files for each platform (we
want to keep these in lockstep), should **never** include `clang-format`
Expand Down

0 comments on commit 804beaf

Please sign in to comment.