Add a few missing overrides found by a new clang warning.

Namely, -Winconsistent-missing-override. No behavior change. BUG=428099 TBR=blundell Review URL: https://codereview.chromium.org/652233006 Cr-Commit-Position: refs/heads/master@{#301761}
marcosholgado · Oct 29, 2014 · 7e7fce4 · 7e7fce4
1 parent e9c0d2e
commit 7e7fce4
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 15 deletions.
diff --git a/base/files/file_path_watcher_win.cc b/base/files/file_path_watcher_win.cc
@@ -39,7 +39,7 @@ class FilePathWatcherImpl : public FilePathWatcher::PlatformDelegate,
   virtual void WillDestroyCurrentMessageLoop() override;
 
   // Callback from MessageLoopForIO.
-  virtual void OnObjectSignaled(HANDLE object);
+  virtual void OnObjectSignaled(HANDLE object) override;
 
  private:
   virtual ~FilePathWatcherImpl() {}

diff --git a/base/win/enum_variant.h b/base/win/enum_variant.h
@@ -33,10 +33,10 @@ class BASE_EXPORT EnumVariant
   // IEnumVARIANT.
   STDMETHODIMP Next(ULONG requested_count,
                     VARIANT* out_elements,
-                    ULONG* out_elements_received);
-  STDMETHODIMP Skip(ULONG skip_count);
-  STDMETHODIMP Reset();
-  STDMETHODIMP Clone(IEnumVARIANT** out_cloned_object);
+                    ULONG* out_elements_received) override;
+  STDMETHODIMP Skip(ULONG skip_count) override;
+  STDMETHODIMP Reset() override;
+  STDMETHODIMP Clone(IEnumVARIANT** out_cloned_object) override;
 
  private:
   ~EnumVariant();

diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h
@@ -235,7 +235,7 @@ class Profile : public content::BrowserContext {
   virtual PrefService* GetOffTheRecordPrefs() = 0;
 
   // Returns the main request context.
-  virtual net::URLRequestContextGetter* GetRequestContext() = 0;
+  virtual net::URLRequestContextGetter* GetRequestContext() override = 0;
 
   // Returns the request context used for extension-related requests.  This
   // is only used for a separate cookie store currently.

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
@@ -201,7 +201,7 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {
  public:
   typedef SafeBrowsingUIManager::UnsafeResource UnsafeResource;
 
-  virtual void SetUp() {
+  virtual void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
 
     // Inject service classes.
@@ -222,7 +222,7 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {
     csd_host_->browse_info_.reset(new BrowseInfo);
   }
 
-  virtual void TearDown() {
+  virtual void TearDown() override {
     // Delete the host object on the UI thread and release the
     // SafeBrowsingService.
     BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE,

diff --git a/chrome/test/base/test_browser_window.h b/chrome/test/base/test_browser_window.h
@@ -73,7 +73,7 @@ class TestBrowserWindow : public BrowserWindow {
   bool IsFullscreen() const override;
 #if defined(OS_WIN)
   virtual void SetMetroSnapMode(bool enable) override {}
-  virtual bool IsInMetroSnapMode() const;
+  virtual bool IsInMetroSnapMode() const override;
 #endif
   bool IsFullscreenBubbleVisible() const override;
   LocationBar* GetLocationBar() const override;

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h
@@ -214,11 +214,11 @@ class PasswordStore : protected PasswordStoreSync,
   // base::Bind can't be used with them because it fails to cast PasswordStore
   // to PasswordStoreSync.
   virtual PasswordStoreChangeList AddLoginImpl(
-      const autofill::PasswordForm& form) = 0;
+      const autofill::PasswordForm& form) override = 0;
   virtual PasswordStoreChangeList UpdateLoginImpl(
-      const autofill::PasswordForm& form) = 0;
+      const autofill::PasswordForm& form) override = 0;
   virtual PasswordStoreChangeList RemoveLoginImpl(
-      const autofill::PasswordForm& form) = 0;
+      const autofill::PasswordForm& form) override = 0;
 
   // Synchronous implementation to remove the given logins.
   virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(

diff --git a/components/storage_monitor/test_volume_mount_watcher_win.h b/components/storage_monitor/test_volume_mount_watcher_win.h
@@ -38,8 +38,6 @@ class TestVolumeMountWatcherWin : public VolumeMountWatcherWin {
 
   void FlushWorkerPoolForTesting();
 
-  virtual void DeviceCheckComplete(const base::FilePath& device_path);
-
   const std::vector<base::FilePath>& devices_checked() const {
       return devices_checked_;
   }
@@ -49,6 +47,7 @@ class TestVolumeMountWatcherWin : public VolumeMountWatcherWin {
   void ReleaseDeviceCheck();
 
   // VolumeMountWatcherWin:
+  virtual void DeviceCheckComplete(const base::FilePath& device_path) override;
   virtual GetAttachedDevicesCallbackType
       GetAttachedDevicesCallback() const override;
   virtual GetDeviceDetailsCallbackType

diff --git a/components/translate/content/browser/browser_cld_data_provider.h b/components/translate/content/browser/browser_cld_data_provider.h
@@ -38,7 +38,7 @@ class BrowserCldDataProvider : public IPC::Listener {
   // OnCldDataRequest() and returns true. In all other cases, this method does
   // nothing. This method is defined as virtual in order to force the
   // implementation to define the specific IPC message(s) that it handles.
-  virtual bool OnMessageReceived(const IPC::Message&) = 0;
+  virtual bool OnMessageReceived(const IPC::Message&) override = 0;
 
   // Called when the browser process receives an appropriate message in
   // OnMessageReceived, above. The implementation should attempt to locate