Revert "Enable SharedArrayBuffer feature by default."

This reverts commit e94f534. Reason for revert: This change appears to break webkit_tests on the WebKit Android (Nexus4) builder: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/64762 TBR=binji,jochen BUG= Review-Url: https://codereview.chromium.org/2876293002 . Cr-Commit-Position: refs/heads/master@{#471510}
marcosholgado · May 13, 2017 · 7c38e38 · 7c38e38
1 parent bec93af
commit 7c38e38
Show file tree

Hide file tree

Showing 92 changed files with 1,038 additions and 211 deletions.
diff --git a/content/public/common/content_features.cc b/content/public/common/content_features.cc
@@ -214,7 +214,7 @@ const base::Feature kServiceWorkerNavigationPreload{
 
 // http://tc39.github.io/ecmascript_sharedmem/shmem.html
 const base::Feature kSharedArrayBuffer{"SharedArrayBuffer",
-                                       base::FEATURE_ENABLED_BY_DEFAULT};
+                                       base::FEATURE_DISABLED_BY_DEFAULT};
 
 // Paint invalidation based on slimming paint. See https://goo.gl/eQczQW
 const base::Feature kSlimmingPaintInvalidation{

diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
@@ -8436,7 +8436,6 @@ crbug.com/591099 fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.ht
 crbug.com/591099 fast/canvas/canvas-createImageBitmap-recursive.html [ Failure Timeout ]
 crbug.com/591099 fast/canvas/canvas-createImageBitmap-svg.html [ Failure ]
 crbug.com/591099 fast/canvas/canvas-createImageBitmap-svg-no-intrinsic-size.html [ Failure ]
-crbug.com/591099 fast/canvas/canvas-createImageBitmap-webgl.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/canvas-createPattern-fillRect-shadow.html [ Crash ]
 crbug.com/591099 fast/canvas/canvas-currentColor.html [ Crash ]
 crbug.com/591099 fast/canvas/canvas-direction.html [ Crash ]
@@ -8525,7 +8524,6 @@ crbug.com/591099 fast/canvas/canvas-text-alignment.html [ Failure ]
 crbug.com/591099 fast/canvas/canvas-text-baseline-tiny-fonts.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/canvas-textMetrics-width.html [ Failure ]
 crbug.com/591099 fast/canvas/canvas-text-space-characters.html [ Crash ]
-crbug.com/591099 fast/canvas/canvas-toDataURL-webp.html [ Crash Pass ]
 crbug.com/591099 fast/canvas/canvas-transforms-during-path.html [ Failure ]
 crbug.com/591099 fast/canvas/canvas-transforms-fillRect-shadow.html [ Crash ]
 crbug.com/591099 fast/canvas/check-stale-putImageData.html [ Crash Pass ]
@@ -8543,8 +8541,6 @@ crbug.com/591099 fast/canvas/fillText-shadow.html [ Crash ]
 crbug.com/591099 fast/canvas/font-no-zoom.html [ Crash ]
 crbug.com/591099 fast/canvas/gradient-with-clip.html [ Crash ]
 crbug.com/591099 fast/canvas/image-object-in-canvas.html [ Failure ]
-crbug.com/591099 fast/canvas/OffscreenCanvas-2d-drawImage.html [ Failure Pass ]
-crbug.com/591099 fast/canvas/OffscreenCanvas-commit-invalid-call.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/OffscreenCanvas-constructor-in-worker.html [ Failure ]
 crbug.com/591099 fast/canvas/OffscreenCanvas-invalid-args-in-worker.html [ Failure ]
 crbug.com/591099 fast/canvas/OffscreenCanvas-transferable-exceptions.html [ Failure ]
@@ -8554,7 +8550,6 @@ crbug.com/591099 fast/canvas/pattern-with-transform.html [ Crash ]
 crbug.com/591099 fast/canvas/pixelated-canvas.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/pixelated-resize.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/quadraticCurveTo.xml [ Failure ]
-crbug.com/591099 fast/canvas/rendering-contexts-back-references.html [ Failure Pass ]
 crbug.com/591099 fast/canvas/resize-while-save-active.html [ Crash ]
 crbug.com/591099 fast/canvas/set-empty-font-crash.html [ Crash ]
 crbug.com/591099 fast/canvas/setWidthResetAfterForcedRender.html [ Failure ]
@@ -10520,7 +10515,6 @@ crbug.com/591099 fast/dom/legend-display-inline.html [ Failure ]
 crbug.com/591099 fast/dom/length-attribute-mapping.html [ Failure ]
 crbug.com/591099 fast/dom/location-hash.html [ Failure ]
 crbug.com/591099 fast/dom/location-new-window-no-crash.html [ Failure ]
-crbug.com/591099 fast/dom/minor-dom-gc.html [ Failure Pass ]
 crbug.com/591099 fast/dom/mutation-event-remove-inserted-node.html [ Failure ]
 crbug.com/591099 fast/dom/MutationObserver/added-out-of-order.html [ Failure ]
 crbug.com/591099 fast/dom/MutationObserver/callback-arguments.html [ Failure ]
@@ -18204,7 +18198,6 @@ crbug.com/591099 http/tests/websocket/connect-error-by-no-websocket-server-close
 crbug.com/591099 http/tests/websocket/connect-error-by-no-websocket-server-noclose.html [ Failure ]
 crbug.com/591099 http/tests/websocket/connection-throttling.html [ Failure ]
 crbug.com/591099 http/tests/websocket/construct-in-detached-frame.html [ Crash ]
-crbug.com/591099 http/tests/websocket/cookie-document-to-ws.html [ Failure Pass ]
 crbug.com/591099 http/tests/websocket/cookie-http-to-ws.pl [ Failure ]
 crbug.com/591099 http/tests/websocket/cookie-ws-to-ws.html [ Failure ]
 crbug.com/591099 http/tests/websocket/cross-origin.html [ Failure ]
@@ -25863,6 +25856,23 @@ crbug.com/591099 virtual/service-worker-navigation-preload-disabled/webexposed/g
 crbug.com/591099 virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker.html [ Timeout ]
 crbug.com/591099 virtual/service-worker-navigation-preload-disabled/webexposed/nonstable-css-properties.html [ Failure ]
 crbug.com/591099 virtual/service-worker-navigation-preload-disabled/webexposed/permissions-attribute.html [ Failure ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/canvas/canvas-createImageBitmap-webgl.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/canvas/canvas-toDataURL-webp.html [ Crash Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/canvas/OffscreenCanvas-2d-drawImage.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/canvas/OffscreenCanvas-commit-invalid-call.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/canvas/rendering-contexts-back-references.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/css/no-recalc-on-no-op-inline-style-changes.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/minor-dom-gc.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/shadow/import-rule-in-shadow-tree-needs-document-style-recalc.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/http/tests/push_messaging/application-server-key-standard-endpoint.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/http/tests/push_messaging/subscribe-failure-mismatched-sender-id.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/http/tests/websocket/cookie-document-to-ws.html [ Failure Pass ]
+crbug.com/591099 virtual/sharedarraybuffer/http/tests/websocket/send-file-blob.html [ Failure Pass ]
 crbug.com/591099 virtual/spv2/compositing/framesets/composited-frame-alignment.html [ Failure ]
 crbug.com/591099 virtual/spv2/compositing/geometry/outline-change.html [ Failure Pass ]
 crbug.com/591099 virtual/spv2/paint/invalidation/margin.html [ Failure Pass ]

diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
@@ -98,6 +98,7 @@ Bug(none) virtual/scalefactor200withzoom/ [ Skip ]
 Bug(none) virtual/scroll_customization/ [ Skip ]
 Bug(none) virtual/service-worker-navigation-preload/ [ Skip ]
 Bug(none) virtual/service-worker-navigation-preload-disabled/ [ Skip ]
+Bug(none) virtual/sharedarraybuffer/ [ Skip ]
 Bug(none) virtual/spv2/ [ Skip ]
 Bug(none) virtual/stable/ [ Skip ]
 Bug(none) virtual/targetedstylerecalc/ [ Skip ]

diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process b/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
@@ -1,6 +1,11 @@
 # These tests currently fail when they run with --site-per-process.
 # See https://crbug.com/477150.
 
+# https://crbug.com/717092: Started failing after r468084 landed.
+crbug.com/717092 virtual/sharedarraybuffer/storage/indexeddb/blob-valid-after-deletion.html [ Failure ]
+crbug.com/717092 virtual/sharedarraybuffer/storage/indexeddb/blob-valid-before-commit.html [ Failure ]
+crbug.com/717092 virtual/sharedarraybuffer/storage/indexeddb/empty-crash.html [ Timeout ]
+
 # https://crbug.com/716085: Started failing after r466634 landed.
 crbug.com/716085 http/tests/feature-policy/payment-allowed-by-container-policy-relocate.html [ Failure ]
 crbug.com/716085 http/tests/feature-policy-experimental-features/vibrate-disabled.php [ Failure ]

diff --git a/third_party/WebKit/LayoutTests/LeakExpectations b/third_party/WebKit/LayoutTests/LeakExpectations
@@ -84,6 +84,7 @@ crbug.com/661182 fast/loader/open-in-srcdoc-unload.html [ Leak ]
 # the tests for IndexedDB are skipped.
 crbug.com/506752 external/wpt/IndexedDB/ [ Skip ]
 crbug.com/506752 storage/indexeddb/ [ Skip ]
+crbug.com/506752 virtual/sharedarraybuffer/storage/indexeddb/ [ Skip ]
 
 # -----------------------------------------------------------------
 # Untriaged but known leaks of ActiveDOMObject (http).

diff --git a/third_party/WebKit/LayoutTests/MSANExpectations b/third_party/WebKit/LayoutTests/MSANExpectations
@@ -13,8 +13,10 @@ crbug.com/420198 [ Linux ] virtual/slimmingpaint/fast/css/fontface-arraybuffer.h
 # a stack overflow due to bloated stack frames under MSan.
 crbug.com/420606 [ Linux ] fast/workers/shared-worker-constructor.html [ Skip ]
 crbug.com/420606 [ Linux ] virtual/slimmingpaint/fast/workers/shared-worker-constructor.html [ Skip ]
+crbug.com/420606 [ Linux ] virtual/sharedarraybuffer/fast/workers/shared-worker-constructor.html [ Skip ]
 crbug.com/420606 [ Linux ] fast/workers/worker-constructor.html [ Skip ]
 crbug.com/420606 [ Linux ] virtual/slimmingpaint/fast/workers/worker-constructor.html [ Skip ]
+crbug.com/420606 [ Linux ] virtual/sharedarraybuffer/fast/workers/worker-constructor.html [ Skip ]
 
 # Flaky under MSan (hang forever).
 crbug.com/422982 [ Linux ] virtual/threaded [ Skip ]

diff --git a/third_party/WebKit/LayoutTests/NeverFixTests b/third_party/WebKit/LayoutTests/NeverFixTests
@@ -39,6 +39,7 @@ fast/harness/sample-fail-mismatch-reftest.html [ WontFix ]
 
 # This test only applies to overlay scrollbar platforms.
 [ Win Linux ] fast/dom/partial-layout-overlay-scrollbars.html [ WontFix ]
+[ Win Linux ] virtual/sharedarraybuffer/fast/dom/partial-layout-overlay-scrollbars.html [ WontFix ]
 
 # Mac's popup behavior is different.
 [ Mac ] fast/forms/select/menulist-onchange-fired-with-key-up-down.html [ WontFix ]
@@ -101,6 +102,12 @@ media/stable [ WontFix ]
 [ Android ] virtual/mojo-loading/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html [ WontFix ]
 [ Android ] virtual/mojo-loading/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html [ WontFix ]
 [ Android ] virtual/mojo-loading/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html [ WontFix ]
+[ Android ] virtual/sharedarraybuffer/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html [ WontFix ]
 
 # Only run fake-Android tests on Linux
 [ Mac Win ] virtual/android [ WontFix ]
@@ -217,6 +224,8 @@ crbug.com/712970 virtual/mojo-loading/http/tests/wasm_streaming/ [ WontFix ]
 # these tests can still be run manually with --skiped=ignore.
 webaudio/codec-tests/mp3 [ WontFix ]
 webaudio/codec-tests/aac [ WontFix ]
+virtual/sharedarraybuffer/webaudio/codec-tests/mp3 [ WontFix ]
+virtual/sharedarraybuffer/webaudio/codec-tests/aac [ WontFix ]
 
 # WPT subdirectories without owners.
 external/wpt/accelerometer [ WontFix ]