Run clang-tidy modernize-use-equals-{delete,default} on //gin

See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: Ib4d1680c615407583a6ad72ce51634d2f444db99 Reviewed-on: https://chromium-review.googlesource.com/789742 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520826}
marcosholgado · Dec 1, 2017 · 756035a · 756035a
1 parent 070940d
commit 756035a
Show file tree

Hide file tree

Showing 21 changed files with 34 additions and 65 deletions.
diff --git a/gin/arguments.cc b/gin/arguments.cc
@@ -23,8 +23,7 @@ Arguments::Arguments(const v8::FunctionCallbackInfo<v8::Value>& info)
       insufficient_arguments_(false) {
 }
 
-Arguments::~Arguments() {
-}
+Arguments::~Arguments() = default;
 
 v8::Local<v8::Value> Arguments::PeekNext() const {
   if (next_ >= info_->Length())

diff --git a/gin/array_buffer.cc b/gin/array_buffer.cc
@@ -231,15 +231,9 @@ ArrayBuffer::ArrayBuffer(v8::Isolate* isolate,
   num_bytes_ = private_->length();
 }
 
-ArrayBuffer::~ArrayBuffer() {
-}
+ArrayBuffer::~ArrayBuffer() = default;
 
-ArrayBuffer& ArrayBuffer::operator=(const ArrayBuffer& other) {
-  private_ = other.private_;
-  bytes_ = other.bytes_;
-  num_bytes_ = other.num_bytes_;
-  return *this;
-}
+ArrayBuffer& ArrayBuffer::operator=(const ArrayBuffer& other) = default;
 
 // Converter<ArrayBuffer> -----------------------------------------------------
 
@@ -266,16 +260,10 @@ ArrayBufferView::ArrayBufferView(v8::Isolate* isolate,
       num_bytes_(view->ByteLength()) {
 }
 
-ArrayBufferView::~ArrayBufferView() {
-}
-
-ArrayBufferView& ArrayBufferView::operator=(const ArrayBufferView& other) {
-  array_buffer_ = other.array_buffer_;
-  offset_ = other.offset_;
-  num_bytes_ = other.num_bytes_;
-  return *this;
-}
+ArrayBufferView::~ArrayBufferView() = default;
 
+ArrayBufferView& ArrayBufferView::operator=(const ArrayBufferView& other) =
+    default;
 
 // Converter<ArrayBufferView> -------------------------------------------------
 

diff --git a/gin/dictionary.cc b/gin/dictionary.cc
@@ -18,8 +18,7 @@ Dictionary::Dictionary(v8::Isolate* isolate,
 
 Dictionary::Dictionary(const Dictionary& other) = default;
 
-Dictionary::~Dictionary() {
-}
+Dictionary::~Dictionary() = default;
 
 Dictionary Dictionary::CreateEmpty(v8::Isolate* isolate) {
   Dictionary dictionary(isolate);

diff --git a/gin/interceptor_unittest.cc b/gin/interceptor_unittest.cc
@@ -91,7 +91,7 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
         IndexedPropertyInterceptor(isolate, this),
         value_(0),
         template_cache_(isolate) {}
-  ~MyInterceptor() override {}
+  ~MyInterceptor() override = default;
 
   // gin::Wrappable
   ObjectTemplateBuilder GetObjectTemplateBuilder(

diff --git a/gin/modules/file_module_provider.cc b/gin/modules/file_module_provider.cc
@@ -54,8 +54,7 @@ FileModuleProvider::FileModuleProvider(
     : search_paths_(search_paths) {
 }
 
-FileModuleProvider::~FileModuleProvider() {
-}
+FileModuleProvider::~FileModuleProvider() = default;
 
 void FileModuleProvider::AttempToLoadModules(
     Runner* runner, const std::set<std::string>& ids) {

diff --git a/gin/modules/module_registry.cc b/gin/modules/module_registry.cc
@@ -44,8 +44,7 @@ struct PendingModule {
   Persistent<Value> factory;
 };
 
-PendingModule::PendingModule() {
-}
+PendingModule::PendingModule() = default;
 
 PendingModule::~PendingModule() {
   factory.Reset();

diff --git a/gin/modules/module_runner_delegate.cc b/gin/modules/module_runner_delegate.cc
@@ -17,8 +17,7 @@ ModuleRunnerDelegate::ModuleRunnerDelegate(
     : module_provider_(search_paths) {
 }
 
-ModuleRunnerDelegate::~ModuleRunnerDelegate() {
-}
+ModuleRunnerDelegate::~ModuleRunnerDelegate() = default;
 
 void ModuleRunnerDelegate::AddBuiltinModule(const std::string& id,
                                             ModuleGetter getter) {

diff --git a/gin/modules/timer.cc b/gin/modules/timer.cc
@@ -54,8 +54,7 @@ Timer::Timer(v8::Isolate* isolate, bool repeating, int delay_ms,
                base::Bind(&Timer::OnTimerFired, weak_factory_.GetWeakPtr()));
 }
 
-Timer::~Timer() {
-}
+Timer::~Timer() = default;
 
 void Timer::OnTimerFired() {
   // This can happen in spite of the weak callback because it is possible for
@@ -97,11 +96,9 @@ v8::Local<v8::Value> TimerModule::GetModule(v8::Isolate* isolate) {
   return Create(isolate)->GetWrapper(isolate).ToLocalChecked();
 }
 
-TimerModule::TimerModule() {
-}
+TimerModule::TimerModule() = default;
 
-TimerModule::~TimerModule() {
-}
+TimerModule::~TimerModule() = default;
 
 ObjectTemplateBuilder TimerModule::GetObjectTemplateBuilder(
     v8::Isolate* isolate) {

diff --git a/gin/modules/timer_unittest.cc b/gin/modules/timer_unittest.cc
@@ -37,7 +37,7 @@ class Result : public Wrappable<Result> {
   Result() : count_(0) {
   }
 
-  ~Result() override {}
+  ~Result() override = default;
 
   ObjectTemplateBuilder GetObjectTemplateBuilder(
       v8::Isolate* isolate) override {

diff --git a/gin/object_template_builder.cc b/gin/object_template_builder.cc
@@ -148,8 +148,7 @@ ObjectTemplateBuilder::ObjectTemplateBuilder(v8::Isolate* isolate)
 ObjectTemplateBuilder::ObjectTemplateBuilder(
     const ObjectTemplateBuilder& other) = default;
 
-ObjectTemplateBuilder::~ObjectTemplateBuilder() {
-}
+ObjectTemplateBuilder::~ObjectTemplateBuilder() = default;
 
 ObjectTemplateBuilder& ObjectTemplateBuilder::AddNamedPropertyInterceptor() {
   template_->SetNamedPropertyHandler(&NamedPropertyGetter,

diff --git a/gin/runner.cc b/gin/runner.cc
@@ -9,16 +9,14 @@ namespace gin {
 Runner::Runner() : weak_factory_(this) {
 }
 
-Runner::~Runner() {
-}
+Runner::~Runner() = default;
 
 Runner::Scope::Scope(Runner* runner)
     : isolate_scope_(runner->GetContextHolder()->isolate()),
       handle_scope_(runner->GetContextHolder()->isolate()),
       scope_(runner->GetContextHolder()->context()) {
 }
 
-Runner::Scope::~Scope() {
-}
+Runner::Scope::~Scope() = default;
 
 }  // namespace gin
diff --git a/gin/shell_runner.cc b/gin/shell_runner.cc
@@ -19,11 +19,9 @@ using v8::Script;
 
 namespace gin {
 
-ShellRunnerDelegate::ShellRunnerDelegate() {
-}
+ShellRunnerDelegate::ShellRunnerDelegate() = default;
 
-ShellRunnerDelegate::~ShellRunnerDelegate() {
-}
+ShellRunnerDelegate::~ShellRunnerDelegate() = default;
 
 v8::Local<ObjectTemplate> ShellRunnerDelegate::GetGlobalTemplate(
     ShellRunner* runner,
@@ -60,8 +58,7 @@ ShellRunner::ShellRunner(ShellRunnerDelegate* delegate, Isolate* isolate)
   delegate_->DidCreateContext(this);
 }
 
-ShellRunner::~ShellRunner() {
-}
+ShellRunner::~ShellRunner() = default;
 
 void ShellRunner::Run(const std::string& source,
                       const std::string& resource_name) {

diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
@@ -44,8 +44,7 @@ FileRunnerDelegate::FileRunnerDelegate()
   AddBuiltinModule(File::kModuleName, File::GetModule);
 }
 
-FileRunnerDelegate::~FileRunnerDelegate() {
-}
+FileRunnerDelegate::~FileRunnerDelegate() = default;
 
 void FileRunnerDelegate::UnhandledException(ShellRunner* runner,
                                             TryCatch& try_catch) {

diff --git a/gin/test/v8_test.cc b/gin/test/v8_test.cc
@@ -15,11 +15,9 @@ using v8::HandleScope;
 
 namespace gin {
 
-V8Test::V8Test() {
-}
+V8Test::V8Test() = default;
 
-V8Test::~V8Test() {
-}
+V8Test::~V8Test() = default;
 
 void V8Test::SetUp() {
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA

diff --git a/gin/try_catch.cc b/gin/try_catch.cc
@@ -25,8 +25,7 @@ TryCatch::TryCatch(v8::Isolate* isolate)
     : isolate_(isolate), try_catch_(isolate) {
 }
 
-TryCatch::~TryCatch() {
-}
+TryCatch::~TryCatch() = default;
 
 bool TryCatch::HasCaught() {
   return try_catch_.HasCaught();

diff --git a/gin/v8_foreground_task_runner.cc b/gin/v8_foreground_task_runner.cc
@@ -17,7 +17,7 @@ V8ForegroundTaskRunner::V8ForegroundTaskRunner(
   DCHECK(task_runner_);
 }
 
-V8ForegroundTaskRunner::~V8ForegroundTaskRunner() {}
+V8ForegroundTaskRunner::~V8ForegroundTaskRunner() = default;
 
 void V8ForegroundTaskRunner::PostTask(std::unique_ptr<v8::Task> task) {
   task_runner_->PostTask(FROM_HERE,

diff --git a/gin/v8_foreground_task_runner_base.cc b/gin/v8_foreground_task_runner_base.cc
@@ -6,9 +6,9 @@
 
 namespace gin {
 
-V8ForegroundTaskRunnerBase::V8ForegroundTaskRunnerBase() {}
+V8ForegroundTaskRunnerBase::V8ForegroundTaskRunnerBase() = default;
 
-V8ForegroundTaskRunnerBase::~V8ForegroundTaskRunnerBase() {}
+V8ForegroundTaskRunnerBase::~V8ForegroundTaskRunnerBase() = default;
 
 void V8ForegroundTaskRunnerBase::EnableIdleTasks(
     std::unique_ptr<V8IdleTaskRunner> idle_task_runner) {

diff --git a/gin/v8_foreground_task_runner_with_locker.cc b/gin/v8_foreground_task_runner_with_locker.cc
@@ -19,7 +19,7 @@ V8ForegroundTaskRunnerWithLocker::V8ForegroundTaskRunnerWithLocker(
   DCHECK(task_runner_);
 }
 
-V8ForegroundTaskRunnerWithLocker::~V8ForegroundTaskRunnerWithLocker() {}
+V8ForegroundTaskRunnerWithLocker::~V8ForegroundTaskRunnerWithLocker() = default;
 
 namespace {
 

diff --git a/gin/v8_platform.cc b/gin/v8_platform.cc
@@ -168,7 +168,7 @@ V8Platform* V8Platform::Get() { return g_v8_platform.Pointer(); }
 
 V8Platform::V8Platform() : tracing_controller_(new TracingControllerImpl) {}
 
-V8Platform::~V8Platform() {}
+V8Platform::~V8Platform() = default;
 
 void V8Platform::OnCriticalMemoryPressure() {
 #if defined(OS_WIN)

diff --git a/gin/wrappable.cc b/gin/wrappable.cc
@@ -10,8 +10,7 @@
 
 namespace gin {
 
-WrappableBase::WrappableBase() {
-}
+WrappableBase::WrappableBase() = default;
 
 WrappableBase::~WrappableBase() {
   wrapper_.Reset();

diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc
@@ -22,7 +22,7 @@ namespace gin {
 class BaseClass {
  public:
   BaseClass() : value_(23) {}
-  virtual ~BaseClass() {}
+  virtual ~BaseClass() = default;
 
   // So the compiler doesn't complain that |value_| is unused.
   int value() const { return value_; }
@@ -51,7 +51,7 @@ class MyObject : public BaseClass,
     return Wrappable<MyObject>::GetObjectTemplateBuilder(isolate)
         .SetProperty("value", &MyObject::value, &MyObject::set_value);
   }
-  ~MyObject() override {}
+  ~MyObject() override = default;
 
  private:
   int value_;
@@ -76,7 +76,7 @@ class MyCallableObject : public Wrappable<MyCallableObject> {
   MyCallableObject() : result_(0) {
   }
 
-  ~MyCallableObject() override {}
+  ~MyCallableObject() override = default;
 
   void Call(int val1, int val2, int val3, const gin::Arguments& arguments) {
     if (arguments.IsConstructCall())