Skip to content

Commit

Permalink
Mark BetterSessionRestoreTests as flaky.
Browse files Browse the repository at this point in the history
They are using a test server with a fixed port number -> they fail if the port
number is already taken.

BUG=156981
NOTRY=true

Review URL: https://codereview.chromium.org/11225020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163153 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
marja@chromium.org committed Oct 20, 2012
1 parent f309fa7 commit 7242938
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions chrome/browser/sessions/better_session_restore_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,28 +87,32 @@ class BetterSessionRestoreTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(BetterSessionRestoreTest);
};

IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, PRE_SessionCookies) {
// crbug.com/156981
IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, FLAKY_PRE_SessionCookies) {
// Set the startup preference to "continue where I left off" and visit a page
// which stores a session cookie.
SessionStartupPref::SetStartupPref(
browser()->profile(), SessionStartupPref(SessionStartupPref::LAST));
StoreDataWithPage("session_cookies.html");
}

IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, SessionCookies) {
// crbug.com/156981
IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, FLAKY_SessionCookies) {
// The browsing session will be continued; just wait for the page to reload
// and check the stored data.
CheckReloadedPage();
}

IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, PRE_SessionStorage) {
// crbug.com/156981
IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, FLAKY_PRE_SessionStorage) {
// Write the data on disk less lazily.
dom_storage::DomStorageArea::DisableCommitDelayForTesting();
SessionStartupPref::SetStartupPref(
browser()->profile(), SessionStartupPref(SessionStartupPref::LAST));
StoreDataWithPage("session_storage.html");
}

IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, SessionStorage) {
// crbug.com/156981
IN_PROC_BROWSER_TEST_F(BetterSessionRestoreTest, FLAKY_SessionStorage) {
CheckReloadedPage();
}

0 comments on commit 7242938

Please sign in to comment.