Reland "Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap …

…size increase" This reverts commit 4a3bc42. Reason for revert: <The needed V8 change has been rolled in version 7.6.116. This CL can be checked in now. > Original change's description: > Revert "Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase" > > This reverts commit 2397118. > > Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.> > > Original change's description: > > Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase > > > > Increase max_old_space_size to 4 GB based on availability of physical memory. > > The purpose of this finch is to support web apps that require more heap space > > for their data sets > > > > Bug:958974 > > > > Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Commit-Queue: Maggie Chen <magchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656851} > > TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 958974 > Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657461} TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org Change-Id: Ifdd7cee050d3e9855539fee14dfd5dee608029ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600715 Reviewed-by: Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657581}
marcosholgado · May 8, 2019 · 7172c01 · 7172c01
1 parent d52d0e2
commit 7172c01
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/gin/gin_features.cc b/gin/gin_features.cc
@@ -18,4 +18,8 @@ const base::Feature kV8FlushBytecode{"V8FlushBytecode",
 const base::Feature kV8MemoryReducerForSmallHeaps{
     "V8MemoryReducerForSmallHeaps", base::FEATURE_ENABLED_BY_DEFAULT};
 
+// Increase V8 heap size to 4GB if the physical memory is bigger than 16 GB.
+const base::Feature kV8HugeMaxOldGenerationSize{
+    "V8HugeMaxOldGenerationSize", base::FEATURE_DISABLED_BY_DEFAULT};
+
 }  // namespace features
diff --git a/gin/gin_features.h b/gin/gin_features.h
@@ -13,6 +13,7 @@ namespace features {
 GIN_EXPORT extern const base::Feature kV8OptimizeJavascript;
 GIN_EXPORT extern const base::Feature kV8FlushBytecode;
 GIN_EXPORT extern const base::Feature kV8MemoryReducerForSmallHeaps;
+GIN_EXPORT extern const base::Feature kV8HugeMaxOldGenerationSize;
 
 }  // namespace features
 

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
@@ -232,6 +232,13 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) {
                                sizeof(no_memory_reducer) - 1);
   }
 
+  if (base::FeatureList::IsEnabled(features::kV8HugeMaxOldGenerationSize)) {
+    static const char huge_max_old_generation_size[] =
+        "--huge_max_old_generation_size";
+    v8::V8::SetFlagsFromString(huge_max_old_generation_size,
+                               sizeof(huge_max_old_generation_size) - 1);
+  }
+
   if (IsolateHolder::kStrictMode == mode) {
     static const char use_strict[] = "--use_strict";
     v8::V8::SetFlagsFromString(use_strict, sizeof(use_strict) - 1);

diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
@@ -5401,6 +5401,25 @@
             ]
         }
     ],
+    "V8HugeMaxOldGenerationSize": [
+        {
+            "platforms": [
+                "android",
+                "chromeos",
+                "linux",
+                "mac",
+                "windows"
+            ],
+            "experiments": [
+                {
+                    "name": "Enabled",
+                    "enable_features": [
+                        "V8HugeMaxOldGenerationSize"
+                    ]
+                }
+            ]
+        }
+    ],
     "V8Ignition": [
         {
             "platforms": [