Skip to content

Commit

Permalink
android: add 25 new languages to bundles only
Browse files Browse the repository at this point in the history
The following 27 locales are being added to Android bundle builds:

     af, as, az, be, bs, eu, fr-CA, gl, hy, is, ka, kk, km, ky, lo,
     mk, mn, my, ne, or, pa, si, sq, ur, uz, zh-HK, zu

The first language ("af") was added in this CL:
  https://crrev.com/c/1941058

This CL adds everything else except for "zh-HK" which is left out
because currently "zh-HK" is mapped to "zh-TW"
https://crbug.com/780847.  A separate CL will add zh-HK.

Note on size increase:
Adding support for a language has an unavoidable increase in
SystemWebview binary size.
Since SystemWebView should support all languages that Android does this
size increase is unavoidable.

There is an increase in size even when language splits are used in
bundles.  A bug has been created to look into this:
- APK Bundles wastes a lot of space in resources.arsc (400kb)
- https://crbug.com/1031645


Bug: 812837
Binary-Size: Size increase is unavoidable (see above).
Change-Id: I77cddf38d28ae8eacf37c3de9a09344646f5afb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952288
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726463}
  • Loading branch information
Trevor Perrier authored and Commit Bot committed Dec 19, 2019
1 parent c8222d2 commit 6a28f6f
Show file tree
Hide file tree
Showing 37 changed files with 884 additions and 17 deletions.
25 changes: 25 additions & 0 deletions android_webview/java/strings/android_webview_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
<output filename="values-af/android_webview_strings.xml" lang="af" type="android" />
<output filename="values-am/android_webview_strings.xml" lang="am" type="android" />
<output filename="values-ar/android_webview_strings.xml" lang="ar" type="android" />
<output filename="values-as/android_webview_strings.xml" lang="as" type="android" />
<output filename="values-az/android_webview_strings.xml" lang="az" type="android" />
<output filename="values-be/android_webview_strings.xml" lang="be" type="android" />
<output filename="values-bg/android_webview_strings.xml" lang="bg" type="android" />
<output filename="values-bn/android_webview_strings.xml" lang="bn" type="android" />
<output filename="values-bs/android_webview_strings.xml" lang="bs" type="android" />
<output filename="values-ca/android_webview_strings.xml" lang="ca" type="android" />
<output filename="values-cs/android_webview_strings.xml" lang="cs" type="android" />
<output filename="values-da/android_webview_strings.xml" lang="da" type="android" />
Expand All @@ -16,34 +20,52 @@
<output filename="values-es/android_webview_strings.xml" lang="es" type="android" />
<output filename="values-es-rUS/android_webview_strings.xml" lang="es-419" type="android" />
<output filename="values-et/android_webview_strings.xml" lang="et" type="android" />
<output filename="values-eu/android_webview_strings.xml" lang="eu" type="android" />
<output filename="values-fa/android_webview_strings.xml" lang="fa" type="android" />
<output filename="values-fi/android_webview_strings.xml" lang="fi" type="android" />
<output filename="values-tl/android_webview_strings.xml" lang="fil" type="android" />
<output filename="values-fr/android_webview_strings.xml" lang="fr" type="android" />
<output filename="values-fr-rCA/android_webview_strings.xml" lang="fr-CA" type="android" />
<output filename="values-gl/android_webview_strings.xml" lang="gl" type="android" />
<output filename="values-gu/android_webview_strings.xml" lang="gu" type="android" />
<output filename="values-hi/android_webview_strings.xml" lang="hi" type="android" />
<output filename="values-hr/android_webview_strings.xml" lang="hr" type="android" />
<output filename="values-hu/android_webview_strings.xml" lang="hu" type="android" />
<output filename="values-hy/android_webview_strings.xml" lang="hy" type="android" />
<output filename="values-in/android_webview_strings.xml" lang="id" type="android" />
<output filename="values-is/android_webview_strings.xml" lang="is" type="android" />
<output filename="values-it/android_webview_strings.xml" lang="it" type="android" />
<output filename="values-iw/android_webview_strings.xml" lang="iw" type="android" />
<output filename="values-ja/android_webview_strings.xml" lang="ja" type="android" />
<output filename="values-ka/android_webview_strings.xml" lang="ka" type="android" />
<output filename="values-kk/android_webview_strings.xml" lang="kk" type="android" />
<output filename="values-km/android_webview_strings.xml" lang="km" type="android" />
<output filename="values-kn/android_webview_strings.xml" lang="kn" type="android" />
<output filename="values-ko/android_webview_strings.xml" lang="ko" type="android" />
<output filename="values-ky/android_webview_strings.xml" lang="ky" type="android" />
<output filename="values-lo/android_webview_strings.xml" lang="lo" type="android" />
<output filename="values-lt/android_webview_strings.xml" lang="lt" type="android" />
<output filename="values-lv/android_webview_strings.xml" lang="lv" type="android" />
<output filename="values-mk/android_webview_strings.xml" lang="mk" type="android" />
<output filename="values-ml/android_webview_strings.xml" lang="ml" type="android" />
<output filename="values-mn/android_webview_strings.xml" lang="mn" type="android" />
<output filename="values-mr/android_webview_strings.xml" lang="mr" type="android" />
<output filename="values-ms/android_webview_strings.xml" lang="ms" type="android" />
<output filename="values-my/android_webview_strings.xml" lang="my" type="android" />
<output filename="values-ne/android_webview_strings.xml" lang="ne" type="android" />
<output filename="values-nl/android_webview_strings.xml" lang="nl" type="android" />
<output filename="values-nb/android_webview_strings.xml" lang="no" type="android" />
<output filename="values-or/android_webview_strings.xml" lang="or" type="android" />
<output filename="values-pa/android_webview_strings.xml" lang="pa" type="android" />
<output filename="values-pl/android_webview_strings.xml" lang="pl" type="android" />
<output filename="values-pt-rBR/android_webview_strings.xml" lang="pt-BR" type="android" />
<output filename="values-pt-rPT/android_webview_strings.xml" lang="pt-PT" type="android" />
<output filename="values-ro/android_webview_strings.xml" lang="ro" type="android" />
<output filename="values-ru/android_webview_strings.xml" lang="ru" type="android" />
<output filename="values-si/android_webview_strings.xml" lang="si" type="android" />
<output filename="values-sk/android_webview_strings.xml" lang="sk" type="android" />
<output filename="values-sl/android_webview_strings.xml" lang="sl" type="android" />
<output filename="values-sq/android_webview_strings.xml" lang="sq" type="android" />
<output filename="values-sr/android_webview_strings.xml" lang="sr" type="android" />
<output filename="values-sv/android_webview_strings.xml" lang="sv" type="android" />
<output filename="values-sw/android_webview_strings.xml" lang="sw" type="android" />
Expand All @@ -52,9 +74,12 @@
<output filename="values-th/android_webview_strings.xml" lang="th" type="android" />
<output filename="values-tr/android_webview_strings.xml" lang="tr" type="android" />
<output filename="values-uk/android_webview_strings.xml" lang="uk" type="android" />
<output filename="values-ur/android_webview_strings.xml" lang="ur" type="android" />
<output filename="values-uz/android_webview_strings.xml" lang="uz" type="android" />
<output filename="values-vi/android_webview_strings.xml" lang="vi" type="android" />
<output filename="values-zh-rCN/android_webview_strings.xml" lang="zh-CN" type="android" />
<output filename="values-zh-rTW/android_webview_strings.xml" lang="zh-TW" type="android" />
<output filename="values-zu/android_webview_strings.xml" lang="zu" type="android" />
</outputs>
<translations>
<file lang="af" path="translations/android_webview_strings_af.xtb" />
Expand Down
25 changes: 25 additions & 0 deletions android_webview/ui/aw_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
<output filename="aw_strings_af.pak" type="data_package" lang="af" />
<output filename="aw_strings_am.pak" type="data_package" lang="am" />
<output filename="aw_strings_ar.pak" type="data_package" lang="ar" />
<output filename="aw_strings_as.pak" type="data_package" lang="as" />
<output filename="aw_strings_az.pak" type="data_package" lang="az" />
<output filename="aw_strings_be.pak" type="data_package" lang="be" />
<output filename="aw_strings_bg.pak" type="data_package" lang="bg" />
<output filename="aw_strings_bn.pak" type="data_package" lang="bn" />
<output filename="aw_strings_bs.pak" type="data_package" lang="bs" />
<output filename="aw_strings_ca.pak" type="data_package" lang="ca" />
<output filename="aw_strings_cs.pak" type="data_package" lang="cs" />
<output filename="aw_strings_da.pak" type="data_package" lang="da" />
Expand All @@ -19,36 +23,54 @@
<output filename="aw_strings_es.pak" type="data_package" lang="es" />
<output filename="aw_strings_es-419.pak" type="data_package" lang="es-419" />
<output filename="aw_strings_et.pak" type="data_package" lang="et" />
<output filename="aw_strings_eu.pak" type="data_package" lang="eu" />
<output filename="aw_strings_fa.pak" type="data_package" lang="fa" />
<output filename="aw_strings_fi.pak" type="data_package" lang="fi" />
<output filename="aw_strings_fil.pak" type="data_package" lang="fil" />
<output filename="aw_strings_fr.pak" type="data_package" lang="fr" />
<output filename="aw_strings_fr-CA.pak" type="data_package" lang="fr-CA" />
<output filename="aw_strings_gl.pak" type="data_package" lang="gl" />
<output filename="aw_strings_gu.pak" type="data_package" lang="gu" />
<output filename="aw_strings_he.pak" type="data_package" lang="he" />
<output filename="aw_strings_hi.pak" type="data_package" lang="hi" />
<output filename="aw_strings_hr.pak" type="data_package" lang="hr" />
<output filename="aw_strings_hu.pak" type="data_package" lang="hu" />
<output filename="aw_strings_hy.pak" type="data_package" lang="hy" />
<output filename="aw_strings_id.pak" type="data_package" lang="id" />
<output filename="aw_strings_is.pak" type="data_package" lang="is" />
<output filename="aw_strings_it.pak" type="data_package" lang="it" />
<output filename="aw_strings_ja.pak" type="data_package" lang="ja" />
<output filename="aw_strings_ka.pak" type="data_package" lang="ka" />
<output filename="aw_strings_kk.pak" type="data_package" lang="kk" />
<output filename="aw_strings_km.pak" type="data_package" lang="km" />
<output filename="aw_strings_kn.pak" type="data_package" lang="kn" />
<output filename="aw_strings_ko.pak" type="data_package" lang="ko" />
<output filename="aw_strings_ky.pak" type="data_package" lang="ky" />
<output filename="aw_strings_lo.pak" type="data_package" lang="lo" />
<output filename="aw_strings_lt.pak" type="data_package" lang="lt" />
<output filename="aw_strings_lv.pak" type="data_package" lang="lv" />
<output filename="aw_strings_mk.pak" type="data_package" lang="mk" />
<output filename="aw_strings_ml.pak" type="data_package" lang="ml" />
<output filename="aw_strings_mn.pak" type="data_package" lang="mn" />
<output filename="aw_strings_mr.pak" type="data_package" lang="mr" />
<output filename="aw_strings_ms.pak" type="data_package" lang="ms" />
<output filename="aw_strings_my.pak" type="data_package" lang="my" />
<output filename="aw_strings_ne.pak" type="data_package" lang="ne" />
<output filename="aw_strings_nl.pak" type="data_package" lang="nl" />
<!-- The translation console uses 'no' for Norwegian Bokmål. It should
be 'nb'. -->
<output filename="aw_strings_nb.pak" type="data_package" lang="no" />
<output filename="aw_strings_or.pak" type="data_package" lang="or" />
<output filename="aw_strings_pa.pak" type="data_package" lang="pa" />
<output filename="aw_strings_pl.pak" type="data_package" lang="pl" />
<output filename="aw_strings_pt-BR.pak" type="data_package" lang="pt-BR" />
<output filename="aw_strings_pt-PT.pak" type="data_package" lang="pt-PT" />
<output filename="aw_strings_ro.pak" type="data_package" lang="ro" />
<output filename="aw_strings_ru.pak" type="data_package" lang="ru" />
<output filename="aw_strings_si.pak" type="data_package" lang="si" />
<output filename="aw_strings_sk.pak" type="data_package" lang="sk" />
<output filename="aw_strings_sl.pak" type="data_package" lang="sl" />
<output filename="aw_strings_sq.pak" type="data_package" lang="sq" />
<output filename="aw_strings_sr.pak" type="data_package" lang="sr" />
<output filename="aw_strings_sv.pak" type="data_package" lang="sv" />
<output filename="aw_strings_sw.pak" type="data_package" lang="sw" />
Expand All @@ -57,9 +79,12 @@
<output filename="aw_strings_th.pak" type="data_package" lang="th" />
<output filename="aw_strings_tr.pak" type="data_package" lang="tr" />
<output filename="aw_strings_uk.pak" type="data_package" lang="uk" />
<output filename="aw_strings_ur.pak" type="data_package" lang="ur" />
<output filename="aw_strings_uz.pak" type="data_package" lang="uz" />
<output filename="aw_strings_vi.pak" type="data_package" lang="vi" />
<output filename="aw_strings_zh-CN.pak" type="data_package" lang="zh-CN" />
<output filename="aw_strings_zh-TW.pak" type="data_package" lang="zh-TW" />
<output filename="aw_strings_zu.pak" type="data_package" lang="zu" />
</outputs>
<translations>
<file path="translations/aw_strings_af.xtb" lang="af" />
Expand Down
19 changes: 18 additions & 1 deletion build/android/lint/suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ Still reading?
<issue id="ButtonStyle" severity="Error">
<ignore regexp="remoting/android/host/res/layout/main.xml"/>
</issue>
<!-- Found in generated android_chrome_strings.xml. -->
<!-- Can be removed when BOM marks are removed: https://crbug.com/1033305-->
<issue id="ByteOrderMark" severity="Error">
<ignore regexp="values-pt-rBR/android_chrome_strings.xml"/>
<ignore regexp="values-si/android_chrome_strings.xml"/>
</issue>
<issue id="ClickableViewAccessibility" severity="ignore"/>
<issue id="CommitPrefEdits">
Expand Down Expand Up @@ -283,14 +284,18 @@ Still reading?
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
</issue>
<!-- Most .xtb files in this group have a % that is not part of a formatted string. https://crbug.com/941164 -->
<issue id="StringFormatInvalid" severity="Error">
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-da/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-et/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-is/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-sq/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-sv/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-tl/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-uz/android_chrome_strings.xml"/>
</issue>
<!-- We have many C++ enums that we don't care about in java -->
<issue id="SwitchIntDef" severity="ignore"/>
Expand All @@ -300,6 +305,10 @@ Still reading?
<issue id="TypographyDashes" severity="Error">
<ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml"/>
</issue>
<!-- If no space is after ... in a translation grit does not automatically change it to … -->
<issue id="TypographyEllipsis" severity="Error">
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-az/android_chrome_strings.xml"/>
</issue>
<!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
<issue id="Typos" severity="ignore"/>
<!-- Our generated enums are allowed to have the same values. -->
Expand All @@ -311,24 +320,32 @@ Still reading?
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-cs/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-in/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-ja/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-km/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-ko/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-lo/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-lt/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-ms/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-my/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-sk/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-th/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-vi/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-zh-rCN/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-zh-rHK/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/android/features/tab_ui/java_strings_grd.resources.zip/values-zh-rTW/android_chrome_tab_ui_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-km/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-lo/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-ms/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-my/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rHK/android_chrome_strings.xml"/>
<ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
</issue>
<issue id="UnusedResources">
Expand Down
Loading

0 comments on commit 6a28f6f

Please sign in to comment.