Skip to content

Commit

Permalink
Change PRESUBMIT warning text for obsolete predeclaration
Browse files Browse the repository at this point in the history
When a patch removes the code that required a predeclaration the PRESUBMIT would
print a warning with a message like "ResourceRequestInfo forward declaration is
becoming useless". I didn't understand the meaning of the message.

Change the message to "ResourceRequestInfo forward declaration is no longer
needed" which hopefully will be easier to understand.

BUG=662195

Review-Url: https://codereview.chromium.org/2890413002
Cr-Commit-Position: refs/heads/master@{#473169}
  • Loading branch information
ricea authored and Commit bot committed May 19, 2017
1 parent 5fcdbcd commit 6416dea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -1732,7 +1732,7 @@ def _CheckUselessForwardDeclarations(input_api, output_api):
for decl in useless_fwd_decls:
if input_api.re.search(r'\b%s\b' % decl, line[1:]):
results.append(output_api.PresubmitPromptWarning(
'%s: %s forward declaration is becoming useless' %
'%s: %s forward declaration is no longer needed' %
(f.LocalPath(), decl)))
useless_fwd_decls.remove(decl)

Expand Down

0 comments on commit 6416dea

Please sign in to comment.