Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
No need to call FilterURL on trustworthy data in RFHI::ShowContextMenu.
Before this CL, RenderFrameHostImpl::ShowContextMenu would call `process->FilterURL(...page_url)`. This call was 1) Incorrect: using `this` frame's (potentially subframe's) process to filter the URL of the main frame (`page_url` comes from `GetMainFrame()->GetLastCommittedURL()` called a few lines above). 2) Unnecessary: `page_url` is trustworthy (i.e. populated on browser-side data, rather than based on UntrustworthyContextMenuParams). After this CL, RenderFrameHostImpl::ShowContextMenu no longer calls FilterURL on A) `page_url` and B) `frame_url` (both of these are based on trustworthy data). Bug: 1257907 Change-Id: I9ed7e0311af5287da668e07d582caa6445fc3f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223130 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#931788}
- Loading branch information