Skip to content

Commit

Permalink
Add content ID scheme to //url/url_constants.*
Browse files Browse the repository at this point in the history
This CL adds the content ID scheme to //url/url_constants.*. This scheme is
specified in https://tools.ietf.org/html/rfc2392. The concrete motivation for
this CL is that an upcoming CL needs to reference the content ID scheme in
order to correctly handle navigations within MHTML documents when using
browser-side navigation.

BUG=623553

Review-Url: https://codereview.chromium.org/2098723003
Cr-Commit-Position: refs/heads/master@{#402185}
  • Loading branch information
colinblundell authored and Commit bot committed Jun 27, 2016
1 parent 531252f commit 5ef36cb
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions url/gurl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,9 @@ TEST(GURLTest, IsStandard) {

GURL c("foo://bar/baz");
EXPECT_FALSE(c.IsStandard());

GURL d("cid:bar@baz");
EXPECT_FALSE(d.IsStandard());
}

TEST(GURLTest, SchemeIsHTTPOrHTTPS) {
Expand Down
1 change: 1 addition & 0 deletions url/url_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const char kAboutBlankURL[] = "about:blank";
const char kAboutScheme[] = "about";
const char kBlobScheme[] = "blob";
const char kContentScheme[] = "content";
const char kContentIDScheme[] = "cid";
const char kDataScheme[] = "data";
const char kFileScheme[] = "file";
const char kFileSystemScheme[] = "filesystem";
Expand Down
1 change: 1 addition & 0 deletions url/url_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ URL_EXPORT extern const char kAboutScheme[];
URL_EXPORT extern const char kBlobScheme[];
// The content scheme is specific to Android for identifying a stored file.
URL_EXPORT extern const char kContentScheme[];
URL_EXPORT extern const char kContentIDScheme[];
URL_EXPORT extern const char kDataScheme[];
URL_EXPORT extern const char kFileScheme[];
URL_EXPORT extern const char kFileSystemScheme[];
Expand Down

0 comments on commit 5ef36cb

Please sign in to comment.