Skip to content

Commit

Permalink
Revert of Check missing headers in the build on CQ (patchset chromium#8
Browse files Browse the repository at this point in the history
… id:160001 of https://codereview.chromium.org/2628543003/ )

Reason for revert:
This CL likely breaks |check_gn_headers| step. See crbug.com/725877 for details.

Original issue's description:
> Check missing headers in the build on CQ
>
> This script is run on the following bots on CQ:
> - linux_chromium_dbg_ng
> - linux_chromium_rel_ng
>
> Note that this script can only be added to bots that have "all"
> in "additional_compile_targets".
>
> BUG=661774
>
> Review-Url: https://codereview.chromium.org/2628543003
> Cr-Commit-Position: refs/heads/master@{#474218}
> Committed: https://chromium.googlesource.com/chromium/src/+/ded5e27012a9b0d50de4b80a16e024fe5106b160

TBR=dpranke@chromium.org,thakis@chromium.org,wychen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661774,725877

Review-Url: https://codereview.chromium.org/2900143004
Cr-Commit-Position: refs/heads/master@{#474256}
  • Loading branch information
vitaliii authored and Commit bot committed May 24, 2017
1 parent de1925c commit 5eba554
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 442 deletions.
3 changes: 1 addition & 2 deletions build/check_gn_headers.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,13 @@ def main():
if args.whitelist:
whitelist = ParseWhiteList(open(args.whitelist).read())
missing -= whitelist
nonexisting -= whitelist

missing = sorted(missing)
nonexisting = sorted(nonexisting)

if args.json:
with open(args.json, 'w') as f:
json.dump(sorted(missing + nonexisting), f)
json.dump(missing, f)

if len(missing) == 0 and len(nonexisting) == 0:
return 0
Expand Down
Loading

0 comments on commit 5eba554

Please sign in to comment.