Skip to content

Commit

Permalink
Make content_shell_test fit isolate naming convention.
Browse files Browse the repository at this point in the history
This allows use of the gtest test generator and easy swarming.

https://chromereviews.googleplex.com/412157013/ is the corresponding internal build CL.

BUG=525873

Review URL: https://codereview.chromium.org/1920753002

Cr-Commit-Position: refs/heads/master@{#389614}
  • Loading branch information
cyberstip authored and Commit bot committed Apr 25, 2016
1 parent 296e0f1 commit 5d2e8c4
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 45 deletions.
2 changes: 1 addition & 1 deletion build/android/buildbot/bb_device_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def I(name, apk, apk_package, test_apk, test_data, isolate_file_path=None,
'org.chromium.content_shell_apk',
'ContentShellTest',
'content:content/test/data/android/device_files',
isolate_file_path='content/content_shell_test_apk.isolate'),
isolate_file_path='content/content_shell_test_data.isolate'),
I('ChromePublic',
'ChromePublic.apk',
'org.chromium.chrome',
Expand Down
36 changes: 20 additions & 16 deletions content/content_shell_test_apk.isolate
Original file line number Diff line number Diff line change
@@ -1,21 +1,25 @@
# Copyright (c) 2014 The Chromium Authors. All rights reserved.
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'conditions': [
['OS=="android"', {
'variables': {
'files': [
'<(DEPTH)/content/test/data/android/',
'<(DEPTH)/content/test/data/media/session/',
'<(DEPTH)/net/data/ssl/certificates/crit-codeSigning-chain.pem',
'<(DEPTH)/net/data/ssl/certificates/eku-test-root.pem',
'<(DEPTH)/net/data/ssl/certificates/invalid_key_usage_cert.der',
'<(DEPTH)/net/data/ssl/certificates/non-crit-codeSigning-chain.pem',
'<(DEPTH)/net/data/ssl/certificates/ok_cert.pem',
'<(DEPTH)/net/data/ssl/certificates/root_ca_cert.pem',
],
},
}],
'includes': [
'../build/android/android.isolate',
'content_shell_test_data.isolate',
],
'variables': {
'command': [
'<(PRODUCT_DIR)/bin/run_content_shell_test_apk',
'--enable-platform-mode',
'-e', 'local',
'--logcat-output-dir', '${ISOLATED_OUTDIR}/logcats',
],
'files': [
'../third_party/proguard/',
'<(PRODUCT_DIR)/apks/ContentShell.apk',
'<(PRODUCT_DIR)/apks/ContentShellTest.apk',
'<(PRODUCT_DIR)/bin/run_content_shell_test_apk',
'<(PRODUCT_DIR)/test.lib.java/ContentShellTest.jar',
'content_shell_test_data.isolate',
]
},
}
25 changes: 0 additions & 25 deletions content/content_shell_test_apk_run.isolate

This file was deleted.

21 changes: 21 additions & 0 deletions content/content_shell_test_data.isolate
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Copyright (c) 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'conditions': [
['OS=="android"', {
'variables': {
'files': [
'<(DEPTH)/content/test/data/android/',
'<(DEPTH)/content/test/data/media/session/',
'<(DEPTH)/net/data/ssl/certificates/crit-codeSigning-chain.pem',
'<(DEPTH)/net/data/ssl/certificates/eku-test-root.pem',
'<(DEPTH)/net/data/ssl/certificates/invalid_key_usage_cert.der',
'<(DEPTH)/net/data/ssl/certificates/non-crit-codeSigning-chain.pem',
'<(DEPTH)/net/data/ssl/certificates/ok_cert.pem',
'<(DEPTH)/net/data/ssl/certificates/root_ca_cert.pem',
],
},
}],
],
}
4 changes: 2 additions & 2 deletions content/content_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -2101,7 +2101,7 @@
'additional_src_dirs': ['public/android/javatests/', ],
'is_test_apk': 1,
'test_type': 'instrumentation',
'isolate_file': 'content_shell_test_apk.isolate',
'isolate_file': 'content_shell_test_data.isolate',
},
'includes': [
'../build/java_apk.gypi',
Expand Down Expand Up @@ -2159,7 +2159,7 @@
'../build/isolate.gypi',
],
'sources': [
'content_shell_test_apk_run.isolate',
'content_shell_test_apk.isolate',
],
},
{
Expand Down
2 changes: 1 addition & 1 deletion content/shell/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ instrumentation_test_apk("content_shell_test_apk") {
apk_under_test = ":content_shell_apk"
apk_name = "ContentShellTest"
android_manifest = "javatests/AndroidManifest.xml"
isolate_file = "../../content_shell_test_apk.isolate"
isolate_file = "../../content_shell_test_data.isolate"
}

if (current_cpu != "x64") {
Expand Down

0 comments on commit 5d2e8c4

Please sign in to comment.