Skip to content

Commit

Permalink
Remove stale TODO.
Browse files Browse the repository at this point in the history
In non-NaCl builds, we've since replaced that file with a call to
BoringSSL's SHA-1, which we ship regardless.

Bug: 47218
Change-Id: Ie61f21378fe00566a218f42a8a3ecd7832eb46f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827385
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700481}
  • Loading branch information
davidben authored and Commit Bot committed Sep 26, 2019
1 parent e6d3e48 commit 5d15833
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions base/hash/sha1.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ namespace base {
//
// to reuse the instance of sha, call sha.Init();

// TODO(jhawkins): Replace this implementation with a per-platform
// implementation using each platform's crypto library. See
// http://crbug.com/47218

class SecureHashAlgorithm {
public:
SecureHashAlgorithm() { Init(); }
Expand Down

0 comments on commit 5d15833

Please sign in to comment.