Skip to content

Commit

Permalink
Reserve fd 5 on Android and bump the base fd to 6.
Browse files Browse the repository at this point in the history
BUG=611470

Review-Url: https://codereview.chromium.org/1998893002
Cr-Commit-Position: refs/heads/master@{#395518}
  • Loading branch information
akmistry authored and Commit bot committed May 24, 2016
1 parent ebdcb57 commit 57d453c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion base/posix/global_descriptors.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ class BASE_EXPORT GlobalDescriptors {
#else
// 3 used by __android_log_write().
// 4 used by... something important on Android M.
static const int kBaseDescriptor = 5;
// 5 used by... something important on Android L... on low-end devices.
// TODO(amistry): An Android, this mechanism is only used for tests since the
// content child launcher spawns a process by creating a new Activity using
// the Android APIs. For tests, come up with a way that doesn't require using
// a pre-defined fd.
static const int kBaseDescriptor = 6;
#endif

// Return the singleton instance of GlobalDescriptors.
Expand Down

0 comments on commit 57d453c

Please sign in to comment.