Skip to content

Commit

Permalink
Update IPC security PRESUBMIT check message to be clearer.
Browse files Browse the repository at this point in the history
I hope.

Bug: none
Change-Id: I72a9c4847700e3f2cac5644c16e6d19149c86aae
Reviewed-on: https://chromium-review.googlesource.com/535056
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479437}
  • Loading branch information
zetafunction authored and Commit Bot committed Jun 14, 2017
1 parent ea96b6a commit 5211169
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ def _CheckIpcOwners(input_api, output_api):
files.extend([' %s' % f.LocalPath() for f in entry['files']])
if missing_lines:
errors.append(
'%s is missing the following lines:\n\n%s\n\nfor changed files:\n%s' %
'%s needs the following lines added:\n\n%s\n\nfor files:\n%s' %
(owners_file, '\n'.join(missing_lines), '\n'.join(files)))

results = []
Expand All @@ -1694,7 +1694,8 @@ def _CheckIpcOwners(input_api, output_api):
else:
output = output_api.PresubmitPromptWarning
results.append(output(
'Found changes to IPC files without a security OWNER!',
'Found OWNERS files that need to be updated for IPC security ' +
'review coverage.\nPlease update the OWNERS files below:',
long_text='\n\n'.join(errors)))

return results
Expand Down

0 comments on commit 5211169

Please sign in to comment.