Skip to content

Commit

Permalink
For estimating usage of "Recent" and "Search" folders, we would like …
Browse files Browse the repository at this point in the history
…to have usage count of them.

This patch adds UMA count into navigateTo() to counting number of navigation to folders for usage ratio of "Recent" and "Search" folders.

BUG=238911
R=arv@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/14703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199089 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
yosin@chromium.org committed May 9, 2013
1 parent 91eaeee commit 515056d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
19 changes: 19 additions & 0 deletions chrome/browser/resources/bookmark_manager/js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,20 @@ var commandShortcutMap = cr.isMac ? {
'undo': 'Ctrl-U+005A',
};

/**
* Mapping for folder id to suffix of UMA. These names will be appeared
* after "BookmarkManager_NavigateTo_" in UMA dashboard.
* @const
*/
var folderMetricsNameMap = {
'1': 'BookmarkBar',
'2': 'Other',
'3': 'Mobile',
'recent': 'Recent',
'q=': 'Search',
'subfolder': 'SubFolder',
};

/**
* Adds an event listener to a node that will remove itself after firing once.
* @param {!Element} node The DOM node to add the listener to.
Expand Down Expand Up @@ -155,6 +169,11 @@ function navigateTo(id, callback) {
return;
}

var metricsId = folderMetricsNameMap[id.replace(/^q=.*/, 'q=')] ||
folderMetricsNameMap['subfolder'];
chrome.metricsPrivate.recordUserAction(
'BookmarkManager_NavigateTo_' + metricsId);

addOneShotEventListener(list, 'load', callback);
updateParentId(id);
}
Expand Down
7 changes: 7 additions & 0 deletions tools/metrics/actions/extract_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,13 @@ def AddBookmarkManagerActions(actions):
actions.add('BookmarkManager_Command_UndoGlobal')
actions.add('BookmarkManager_Command_UndoNone')

actions.add('BookmarkManager_NavigateTo_BookmarkBar')
actions.add('BookmarkManager_NavigateTo_Mobile')
actions.add('BookmarkManager_NavigateTo_Other')
actions.add('BookmarkManager_NavigateTo_Recent')
actions.add('BookmarkManager_NavigateTo_Search')
actions.add('BookmarkManager_NavigateTo_SubFolder')

def AddChromeOSActions(actions):
"""Add actions reported by non-Chrome processes in Chrome OS.
Expand Down

0 comments on commit 515056d

Please sign in to comment.