Skip to content

Commit

Permalink
Clean up DEPS rules against content so that not all chrome code can i…
Browse files Browse the repository at this point in the history
…nclude anything from content.

I also moved ChromeContentPluginClient to chrome\plugin where it really belongs (i.e. to match what we do with the utility client).
Review URL: http://codereview.chromium.org/8095011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103569 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jam@chromium.org committed Sep 30, 2011
1 parent a6adbe5 commit 4a68c9e
Show file tree
Hide file tree
Showing 15 changed files with 42 additions and 21 deletions.
4 changes: 3 additions & 1 deletion chrome/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
include_rules = [
"+content",
"+crypto",
"+gpu",
"+net",
Expand All @@ -12,6 +11,9 @@ include_rules = [
"-chrome",
"+chrome/common",
"+chrome/test",
"-content",
"+content/common",
"+content/test",

# Don't allow inclusion of these other libs we shouldn't be calling directly.
"-v8",
Expand Down
4 changes: 4 additions & 0 deletions chrome/app/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ include_rules = [
"+breakpad",
"+chrome/browser",
"+chrome/installer",
"+chrome/plugin/chrome_content_plugin_client.h",
"+chrome/renderer/chrome_content_renderer_client.h",
"+chrome/utility/chrome_content_utility_client.h",
"+content/app",
"+content/browser/renderer_host/render_process_host.h",
"+content/renderer/renderer_main.h",
"+grit", # For generated headers
"+media/base", # For initializing media library.
"+policy", # For generated headers and source
Expand Down
2 changes: 1 addition & 1 deletion chrome/app/chrome_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
#include "chrome/browser/diagnostics/diagnostics_main.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/chrome_content_plugin_client.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_paths_internal.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/logging_chrome.h"
#include "chrome/common/profiling.h"
#include "chrome/common/url_constants.h"
#include "chrome/plugin/chrome_content_plugin_client.h"
#include "chrome/renderer/chrome_content_renderer_client.h"
#include "chrome/utility/chrome_content_utility_client.h"
#include "content/app/content_main.h"
Expand Down
3 changes: 2 additions & 1 deletion chrome/browser/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ include_rules = [
"+chrome/app/locales",
"+chrome/installer",
"+chrome/personalization",
"+chrome/plugin", # For Mac plugin interpose library.
"+chrome/profile_import",
"+chrome/tools/profiles", # For history unit tests.
"+chrome/views",
"+content/browser",
"+content/plugin/plugin_interpose_util_mac.h",
"+grit", # For generated headers
"+media/audio", # For audio input for speech input feature.
"+policy", # For generated headers and source
Expand Down
17 changes: 17 additions & 0 deletions chrome/chrome.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
'browser',
'debugger',
'profile_import',
'plugin',
'renderer',
'syncapi_core',
'utility',
Expand Down Expand Up @@ -437,6 +438,22 @@
}],
],
},
{
'target_name': 'plugin',
'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
'../content/content.gyp:content_plugin',
],
'sources': [
'plugin/chrome_content_plugin_client.cc',
'plugin/chrome_content_plugin_client.h',
],
'include_dirs': [
'..',
'<(grit_out_dir)',
],
},
{
'target_name': 'utility',
'type': 'static_library',
Expand Down
2 changes: 0 additions & 2 deletions chrome/chrome_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@
'common/child_process_logging_win.cc',
'common/chrome_content_client.cc',
'common/chrome_content_client.h',
'common/chrome_content_plugin_client.cc',
'common/chrome_content_plugin_client.h',
'common/chrome_notification_types.h',
'common/chrome_plugin_messages.h',
'common/chrome_version_info.cc',
Expand Down
1 change: 0 additions & 1 deletion chrome/chrome_renderer.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
'chrome_strings',
'safe_browsing_proto',
'../content/content.gyp:content_renderer',
'../content/content.gyp:content_plugin',
'../net/net.gyp:net',
'../ppapi/ppapi_internal.gyp:ppapi_proxy',
'../printing/printing.gyp:printing',
Expand Down
11 changes: 2 additions & 9 deletions chrome/nacl/DEPS
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
include_rules = [
# TODO(mseaborn): Remove chrome/renderer from this list. This is
# here because we need chrome/renderer/renderer_sandbox_support_linux.h
# for creating shared memory segments. We should probably move this
# sandbox support code out of chrome/renderer. (Previously, this
# header was #included from the native_client directory, which was
# worse.)
"+chrome/app",
"+chrome/renderer",
"+chrome/test",
"+chrome/app/breakpad_win.h",
"+content/app/startup_helper_win.h",
"+sandbox/src",
"+native_client/src",
]
4 changes: 4 additions & 0 deletions chrome/plugin/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
include_rules = [
"+content/plugin",
"+grit",
]
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/common/chrome_content_plugin_client.h"
#include "chrome/plugin/chrome_content_plugin_client.h"

#include "chrome/common/default_plugin.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef CHROME_COMMON_CHROME_CONTENT_PLUGIN_CLIENT_H_
#define CHROME_COMMON_CHROME_CONTENT_PLUGIN_CLIENT_H_
#ifndef CHROME_PLUGIN_CHROME_CONTENT_PLUGIN_CLIENT_H_
#define CHROME_PLUGIN_CHROME_CONTENT_PLUGIN_CLIENT_H_
#pragma once

#include "base/compiler_specific.h"
Expand All @@ -18,4 +18,4 @@ class ChromeContentPluginClient : public content::ContentPluginClient {

} // namespace chrome

#endif // CHROME_COMMON_CHROME_CONTENT_PLUGIN_CLIENT_H_
#endif // CHROME_PLUGIN_CHROME_CONTENT_PLUGIN_CLIENT_H_
2 changes: 1 addition & 1 deletion chrome/renderer/DEPS
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
include_rules = [
"+chrome/app", # The plugins use the theme library to get the sad plugin bitmap.
"+chrome/plugin",
"+content/renderer",
"+grit", # For generated headers
"+media/base", # For initializing media library and media switches.
"+ppapi/native_client/src/trusted/plugin/nacl_entry_points.h", # For NaCl registration.
Expand Down
3 changes: 2 additions & 1 deletion chrome/test/DEPS
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
include_rules = [
# The test directory can do whatever it wants in chrome.
# The test directory can do whatever it wants in chrome and content.
"+chrome",
"+content",
"+grit", # For generated headers
"+sandbox/src",
"+sandbox/tests",
Expand Down
1 change: 1 addition & 0 deletions chrome/tools/DEPS
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
include_rules = [
"+chrome/browser",
"+chrome/third_party/hunspell/google",
"+content/browser",
]
1 change: 1 addition & 0 deletions chrome/utility/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
include_rules = [
"+content/utility",
"+webkit/glue",
]

0 comments on commit 4a68c9e

Please sign in to comment.