Skip to content

Commit

Permalink
Revert "[omnibox] Enable keyword search button by default."
Browse files Browse the repository at this point in the history
This reverts commit 4ad67f3.

Reason for revert: We're holding off on rolling this out while we evaluate some changes to how triggering works.

Original change's description:
> [omnibox] Enable keyword search button by default.
>
> Also update unit tests to use Suggestion Button
> Row/Keyword Search Button test by default.
>
> Bug: 1046523
> Change-Id: Icbb41a9a10844b363d6d9fb89c401266b4858576
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2674166
> Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#851918}

Bug: 1046523
Change-Id: I8b6796f8e466b823792999eb869dc20ca4c24bd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2701652
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#854975}
  • Loading branch information
justindonnelly authored and Chromium LUCI CQ committed Feb 17, 2021
1 parent b721d68 commit 3b8643f
Show file tree
Hide file tree
Showing 4 changed files with 292 additions and 94 deletions.
4 changes: 4 additions & 0 deletions components/omnibox/browser/autocomplete_controller.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@ class AutocompleteController : public AutocompleteProviderListener,
PopupStepSelectionWithHiddenGroupIds);
FRIEND_TEST_ALL_PREFIXES(OmniboxPopupModelTest,
PopupInlineAutocompleteAndTemporaryText);
FRIEND_TEST_ALL_PREFIXES(OmniboxPopupModelSuggestionButtonRowTest,
PopupStepSelectionWithButtonRow);
FRIEND_TEST_ALL_PREFIXES(OmniboxPopupModelSuggestionButtonRowTest,
PopupStepSelectionWithButtonRowAndKeywordButton);
FRIEND_TEST_ALL_PREFIXES(OmniboxPopupContentsViewTest,
EmitSelectedChildrenChangedAccessibilityEvent);

Expand Down
Loading

0 comments on commit 3b8643f

Please sign in to comment.