forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Hera] Excise a bunch of document mode code
Deprecated document mode code is hindering efforts to refactor other classes. Excise as much DocumentActivity related code as possible in one swoop so that it's easy to find later, if for some reason it's needed. * Force all users entering DocumentActivity through the migration pathway without checking if they're in document mode. There should be no valid way to trigger a DocumentActivity, short of being inside Recents when migration is completed and reselecting an old Document tab. * Delete practically everything inside the DocumentActivity class to make it easier to determine dead dependencies in classes that are being refactored. * Delete all DocumentActivity-launching related functions from ChromeLauncherActivity, and things that spiral out from there. * Delete most of the document mode tests. * Deletes a bunch of DocumentTabModel related code. Migration pathways still seem to be intact. BUG=582539 Review-Url: https://codereview.chromium.org/2011433003 Cr-Commit-Position: refs/heads/master@{#396062}
- Loading branch information
dfalcantara
authored and
Commit bot
committed
May 26, 2016
1 parent
4c34ac5
commit 35eb7ce
Showing
32 changed files
with
71 additions
and
6,064 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
473 changes: 17 additions & 456 deletions
473
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
Large diffs are not rendered by default.
Oops, something went wrong.
824 changes: 18 additions & 806 deletions
824
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
Large diffs are not rendered by default.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentTabDelegateFactory.java
This file was deleted.
Oops, something went wrong.
98 changes: 0 additions & 98 deletions
98
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.