Skip to content

Commit

Permalink
Removes the OWNERS expansion test from metrics_python_tests.
Browse files Browse the repository at this point in the history
This test is unnecessary because the bots already fail when there is an
invalid path to an OWNERS file in histograms.xml.

CL with failing bots: crrev.com/c/1745447.

Some existing tests, e.g. generate_expired_histograms_array.py, and the
validate_format.py PRESUBMIT merge the histograms, which also performs
OWNERS expansion. Any OWNERS expansion errors are already caught and
will prevent a CL from being submitted.

Bug: 924136
Change-Id: I9205fe4ce08703ac1f7f10b1c0d0e19eef829361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749247
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686034}
  • Loading branch information
Caitlin Fischer authored and Commit Bot committed Aug 12, 2019
1 parent bccea73 commit 35df04d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 40 deletions.
1 change: 0 additions & 1 deletion tools/metrics/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ group("metrics_python_tests") {

"//tools/metrics/histograms/enums.xml",
"//tools/metrics/histograms/expand_owners.py",
"//tools/metrics/histograms/expand_owners_in_histograms_xml_unittest.py",
"//tools/metrics/histograms/expand_owners_unittest.py",
"//tools/metrics/histograms/extract_histograms.py",
"//tools/metrics/histograms/generate_expired_histograms_array.py",
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion tools/metrics/metrics_python_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def resolve(*paths):

sys.exit(typ.main(tests=resolve(
'actions/extract_actions_test.py',
'histograms/expand_owners_in_histograms_xml_unittest.py',
'histograms/generate_expired_histograms_array_unittest.py',
'histograms/pretty_print_test.py',
'rappor/rappor_model_test.py',
Expand Down

0 comments on commit 35df04d

Please sign in to comment.