Skip to content

Commit

Permalink
Explicitly cast istream to bool in file_system_dir_url_request_job_un…
Browse files Browse the repository at this point in the history
…ittest.cc.

Implicit cast is forbidden in libc++.

BUG=318770
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/121823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242637 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
earthdok@chromium.org committed Dec 27, 2013
1 parent 40d99a5 commit 2c33361
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -248,18 +248,18 @@ TEST_F(FileSystemDirURLRequestJobTest, DirectoryListing) {

std::istringstream in(delegate_->data_received());
std::string line;
EXPECT_TRUE(std::getline(in, line));
EXPECT_TRUE(!!std::getline(in, line));

#if defined(OS_WIN)
EXPECT_EQ("<script>start(\"foo\\\\bar\");</script>", line);
#elif defined(OS_POSIX)
EXPECT_EQ("<script>start(\"/foo/bar\");</script>", line);
#endif

EXPECT_TRUE(std::getline(in, line));
EXPECT_TRUE(!!std::getline(in, line));
VerifyListingEntry(line, "hoge", "hoge", false, 10);

EXPECT_TRUE(std::getline(in, line));
EXPECT_TRUE(!!std::getline(in, line));
VerifyListingEntry(line, "baz", "baz", true, 0);
}

Expand Down Expand Up @@ -307,8 +307,8 @@ TEST_F(FileSystemDirURLRequestJobTest, Incognito) {

std::istringstream in(delegate_->data_received());
std::string line;
EXPECT_TRUE(std::getline(in, line));
EXPECT_FALSE(std::getline(in, line));
EXPECT_TRUE(!!std::getline(in, line));
EXPECT_FALSE(!!std::getline(in, line));

TestRequestWithContext(CreateFileSystemURL("foo"),
file_system_context.get());
Expand Down

0 comments on commit 2c33361

Please sign in to comment.