Skip to content

Commit

Permalink
Update TracingControllerTest.DisableRecordingStoresMetadata test
Browse files Browse the repository at this point in the history
Test expects cpu_brand length to be > 0, but cpu_brand is set based on
"Processor" or "model name" values existing in /proc/cpuinfo file.
Values are not guaranteed to exist as shown in comments from i/313454.
Tests updated to match.

BUG=313454
TEST=Existing tests pass

Change-Id: I03e0f1c9e4f6df5325055fbec2345357de9758c1
Reviewed-on: https://chromium-review.googlesource.com/999963
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551900}
  • Loading branch information
KH-AMZN authored and Commit Bot committed Apr 19, 2018
1 parent 6abcea2 commit 21c82d8
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions content/browser/tracing/tracing_controller_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,6 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest, DisableRecordingStoresMetadata) {
std::string os_name;
last_metadata()->GetString("os-name", &os_name);
EXPECT_TRUE(os_name.length() > 0);
std::string cpu_brand;
last_metadata()->GetString("cpu-brand", &cpu_brand);
EXPECT_TRUE(cpu_brand.length() > 0);
std::string command_line;
last_metadata()->GetString("command_line", &command_line);
EXPECT_TRUE(command_line.length() > 0);
Expand All @@ -408,10 +405,6 @@ IN_PROC_BROWSER_TEST_F(TracingControllerTest,
TestStartAndStopTracingStringWithFilter();
// Check that a number of important keys exist in the metadata dictionary.
EXPECT_TRUE(last_metadata() != nullptr);
std::string cpu_brand;
last_metadata()->GetString("cpu-brand", &cpu_brand);
EXPECT_TRUE(cpu_brand.length() > 0);
EXPECT_TRUE(cpu_brand != "__stripped__");
std::string network_type;
last_metadata()->GetString("network-type", &network_type);
EXPECT_TRUE(network_type.length() > 0);
Expand Down

0 comments on commit 21c82d8

Please sign in to comment.