Skip to content

Commit

Permalink
CFI: fix invalid cast in tile_manager_unittest.cc.
Browse files Browse the repository at this point in the history
TaskSetFinishedTaskImpl was casted to its sibling,
cc::RasterTask instead of a base class, cc::TileTask.

This is a follow up to https://codereview.chromium.org/1470113002 which introduced this bad cast.

BUG=565515,464797
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1494273002

Cr-Commit-Position: refs/heads/master@{#363063}
  • Loading branch information
gkrasin authored and Commit bot committed Dec 3, 2015
1 parent 0d063c3 commit 1fd302b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cc/tiles/tile_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1730,7 +1730,7 @@ class CancellingTileTaskRunner : public FakeTileTaskRunner {
// Just call CompleteOnOriginThread on each item in the queue. As none of
// these items have run yet, they will be treated as cancelled tasks.
for (const auto& node : graph->nodes) {
static_cast<RasterTask*>(node.task)->CompleteOnOriginThread(this);
static_cast<TileTask*>(node.task)->CompleteOnOriginThread(this);
}
}
};
Expand Down Expand Up @@ -1805,7 +1805,7 @@ class VerifyResourceContentIdTileTaskRunner : public FakeTileTaskRunner {

void ScheduleTasks(TaskGraph* graph) override {
for (const auto& node : graph->nodes) {
RasterTask* task = static_cast<RasterTask*>(node.task);
TileTask* task = static_cast<TileTask*>(node.task);
// Triggers a call to AcquireBufferForRaster.
task->ScheduleOnOriginThread(this);
// Calls TileManager as though task was cancelled.
Expand Down

0 comments on commit 1fd302b

Please sign in to comment.