Skip to content

Commit

Permalink
Add knowledge of EarlGrey test files to PRESUBMIT.py.
Browse files Browse the repository at this point in the history
EarlGrey is the framework used for integration tests on iOS and the
corresponding test files are by convention named *_egtest.mm.  Add
the pattern to PRESUBMIT.py so that no warning is printed if there
is code calling test functions in those files.

Remove knowledge about KIF test files as this is no longer used.

BUG=666375

Review-Url: https://codereview.chromium.org/2582223002
Cr-Commit-Position: refs/heads/master@{#439432}
  • Loading branch information
sdefresne authored and Commit bot committed Dec 19, 2016
1 parent 476bd13 commit 1fccb0a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
_TEST_CODE_EXCLUDED_PATHS = (
r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS,
r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS,
r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' %
r'.+_(api|browser|eg|perf|pixel|unit|ui)?test(_[a-z]+)?%s' %
_IMPLEMENTATION_EXTENSIONS,
r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS,
r'.*[\\\/](test|tool(s)?)[\\\/].*',
Expand Down

0 comments on commit 1fccb0a

Please sign in to comment.