Skip to content

Commit

Permalink
DanglingPtr: triage dangling ptrs
Browse files Browse the repository at this point in the history
Bug: 1291138
Change-Id: Iad9b09db509b1426d896c17020250b1d8a252209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846295
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038273}
  • Loading branch information
Ali Hijazi authored and Chromium LUCI CQ committed Aug 23, 2022
1 parent 62e5277 commit 1e598fa
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion components/sqlite_proto/key_value_data.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class KeyValueData {
void FlushDataToDisk();

scoped_refptr<TableManager> manager_;
raw_ptr<KeyValueTable<T>> backend_table_;
raw_ptr<KeyValueTable<T>, DanglingUntriaged> backend_table_;
std::unique_ptr<std::map<std::string, T>> data_cache_;
std::unordered_map<std::string, DeferredOperation> deferred_updates_;
base::RepeatingTimer flush_timer_;
Expand Down
2 changes: 1 addition & 1 deletion components/sqlite_proto/table_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class TableManager : public base::RefCountedThreadSafe<TableManager> {
friend class base::RefCountedThreadSafe<TableManager>;

scoped_refptr<base::SequencedTaskRunner> db_task_runner_;
raw_ptr<sql::Database> db_;
raw_ptr<sql::Database, DanglingUntriaged> db_;
};

} // namespace sqlite_proto
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class AggregationServiceInternalsWebUiBrowserTest : public ContentBrowserTest {
}

protected:
raw_ptr<MockAggregationService> aggregation_service_;
raw_ptr<MockAggregationService, DanglingUntriaged> aggregation_service_;
};

IN_PROC_BROWSER_TEST_F(AggregationServiceInternalsWebUiBrowserTest,
Expand Down
2 changes: 1 addition & 1 deletion ipc/ipc_sync_channel.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class COMPONENT_EXPORT(IPC) SyncChannel : public ChannelProxy {

scoped_refptr<ReceivedSyncMsgQueue> received_sync_msgs_;

raw_ptr<base::WaitableEvent> shutdown_event_;
raw_ptr<base::WaitableEvent, DanglingUntriaged> shutdown_event_;
base::WaitableEventWatcher shutdown_watcher_;
base::WaitableEventWatcher::EventCallback shutdown_watcher_callback_;
int restrict_dispatch_group_;
Expand Down

0 comments on commit 1e598fa

Please sign in to comment.