Remove non-source sources from binary targets

No behavior changes. BUG=964411 Change-Id: I23f713944ece4b34aa886612a74b67c210d2346f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617562 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#661791}
marcosholgado · May 21, 2019 · 1a9b0f2 · 1a9b0f2
1 parent 46053ef
commit 1a9b0f2
Show file tree

Hide file tree

Showing 15 changed files with 14 additions and 84 deletions.
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
@@ -330,20 +330,6 @@ jumbo_static_library("renderer") {
       "media/cast_transport_ipc.h",
       "media/cast_udp_transport.cc",
       "media/cast_udp_transport.h",
-      "resources/extensions/browser_action_custom_bindings.js",
-      "resources/extensions/declarative_content_custom_bindings.js",
-      "resources/extensions/enterprise_platform_keys_custom_bindings.js",
-      "resources/extensions/gcm_custom_bindings.js",
-      "resources/extensions/identity_custom_bindings.js",
-      "resources/extensions/image_writer_private_custom_bindings.js",
-      "resources/extensions/input.ime_custom_bindings.js",
-      "resources/extensions/notifications_custom_bindings.js",
-      "resources/extensions/omnibox_custom_bindings.js",
-      "resources/extensions/page_action_custom_bindings.js",
-      "resources/extensions/page_capture_custom_bindings.js",
-      "resources/extensions/system_indicator_custom_bindings.js",
-      "resources/extensions/tts_custom_bindings.js",
-      "resources/extensions/tts_engine_custom_bindings.js",
     ]
     deps += [
       # TODO(hclam): See crbug.com/298380 for details.

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
@@ -2555,7 +2555,7 @@ if (is_mac) {
 }
 
 test("unit_tests") {
-  sources = [
+  inputs = [
     # enums.xml is analyzed by AboutFlagsHistogramTest, so this
     # dependency is needed to make commit bots run unit_tests on
     # enums.xml changes.
@@ -2566,7 +2566,8 @@ test("unit_tests") {
     # flag-never-expire-list.json.
     "../browser/flag-metadata.json",
     "../browser/flag-never-expire-list.json",
-
+  ]
+  sources = [
     # All unittests in browser, common, renderer and service.
     "../browser/about_flags_unittest.cc",
     "../browser/active_use_util_unittest.cc",

diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni
@@ -116,7 +116,7 @@ template("js2gtest") {
                              "defines",
                              "visibility",
                            ])
-    sources = get_target_outputs(":$action_name")
+    sources = process_file_template(invoker.sources, [ gen_source_pattern ])
 
     # This empty public header is intentional to remove unnecessary build
     # dependency.

diff --git a/components/encrypted_messages/BUILD.gn b/components/encrypted_messages/BUILD.gn
@@ -6,7 +6,6 @@ import("//third_party/protobuf/proto_library.gni")
 
 static_library("encrypted_messages") {
   sources = [
-    "encrypted_message.proto",
     "message_encrypter.cc",
     "message_encrypter.h",
   ]

diff --git a/components/policy/core/common/BUILD.gn b/components/policy/core/common/BUILD.gn
@@ -331,7 +331,6 @@ source_set("common_constants") {
 source_set("unit_tests") {
   testonly = true
   sources = [
-    "//extensions/buildflags",
     "cloud/cloud_policy_client_unittest.cc",
     "cloud/cloud_policy_core_unittest.cc",
     "cloud/cloud_policy_manager_unittest.cc",

diff --git a/components/subresource_filter/tools/ruleset_converter/BUILD.gn b/components/subresource_filter/tools/ruleset_converter/BUILD.gn
@@ -4,7 +4,6 @@
 
 source_set("support") {
   sources = [
-    "//third_party/protobuf:protobuf_lite",
     "rule_stream.cc",
     "rule_stream.h",
     "ruleset_converter.cc",

diff --git a/components/variations/BUILD.gn b/components/variations/BUILD.gn
@@ -30,9 +30,6 @@ static_library("variations") {
     "pref_names.h",
     "processed_study.cc",
     "processed_study.h",
-    "proto/client_variations.proto",
-    "proto/study.proto",
-    "proto/variations_seed.proto",
     "seed_response.cc",
     "seed_response.h",
     "study_filtering.cc",

diff --git a/extensions/renderer/BUILD.gn b/extensions/renderer/BUILD.gn
@@ -182,60 +182,6 @@ jumbo_source_set("renderer") {
     "renderer_extension_registry.h",
     "resource_bundle_source_map.cc",
     "resource_bundle_source_map.h",
-    "resources/app_runtime_custom_bindings.js",
-    "resources/app_window_custom_bindings.js",
-    "resources/automation/automation_custom_bindings.js",
-    "resources/context_menus_custom_bindings.js",
-    "resources/declarative_webrequest_custom_bindings.js",
-    "resources/entry_id_manager.js",
-    "resources/extension.css",
-    "resources/extension_fonts.css",
-    "resources/feedback_private_custom_bindings.js",
-    "resources/file_entry_binding_util.js",
-    "resources/file_system_custom_bindings.js",
-    "resources/greasemonkey_api.js",
-    "resources/guest_view/app_view/app_view.js",
-    "resources/guest_view/app_view/app_view_element.js",
-    "resources/guest_view/extension_options/extension_options.js",
-    "resources/guest_view/extension_options/extension_options_attributes.js",
-    "resources/guest_view/extension_options/extension_options_constants.js",
-    "resources/guest_view/extension_options/extension_options_element.js",
-    "resources/guest_view/extension_options/extension_options_events.js",
-    "resources/guest_view/extension_view/extension_view.js",
-    "resources/guest_view/extension_view/extension_view_api_methods.js",
-    "resources/guest_view/extension_view/extension_view_attributes.js",
-    "resources/guest_view/extension_view/extension_view_constants.js",
-    "resources/guest_view/extension_view/extension_view_element.js",
-    "resources/guest_view/extension_view/extension_view_events.js",
-    "resources/guest_view/extension_view/extension_view_internal.js",
-    "resources/guest_view/guest_view.js",
-    "resources/guest_view/guest_view_attributes.js",
-    "resources/guest_view/guest_view_container.js",
-    "resources/guest_view/guest_view_container_element.js",
-    "resources/guest_view/guest_view_deny.js",
-    "resources/guest_view/guest_view_events.js",
-    "resources/guest_view/guest_view_iframe.js",
-    "resources/guest_view/guest_view_iframe_container.js",
-    "resources/guest_view/safe_methods.js",
-    "resources/guest_view/web_view/extensions_web_view_element.js",
-    "resources/guest_view/web_view/web_view.js",
-    "resources/guest_view/web_view/web_view_action_requests.js",
-    "resources/guest_view/web_view/web_view_api_methods.js",
-    "resources/guest_view/web_view/web_view_attributes.js",
-    "resources/guest_view/web_view/web_view_constants.js",
-    "resources/guest_view/web_view/web_view_element.js",
-    "resources/guest_view/web_view/web_view_events.js",
-    "resources/guest_view/web_view/web_view_internal.js",
-    "resources/guest_view/web_view/web_view_request_custom_bindings.js",
-    "resources/image_util.js",
-    "resources/permissions_custom_bindings.js",
-    "resources/platform_app.css",
-    "resources/platform_app.js",
-    "resources/set_icon.js",
-    "resources/test_custom_bindings.js",
-    "resources/uncaught_exception_handler.js",
-    "resources/utils.js",
-    "resources/web_request_custom_bindings.js",
     "runtime_custom_bindings.cc",
     "runtime_custom_bindings.h",
     "runtime_hooks_delegate.cc",

diff --git a/headless/BUILD.gn b/headless/BUILD.gn
@@ -492,7 +492,7 @@ jumbo_component("headless_non_renderer") {
   # use external v8 startup data too.
   if ((is_win && is_component_build) || !is_win) {
     if (v8_use_external_startup_data) {
-      sources += [ "$root_out_dir/natives_blob.bin" ]
+      data += [ "$root_out_dir/natives_blob.bin" ]
       public_deps += [ "//v8" ]
       if (use_v8_context_snapshot) {
         data += [ "$root_out_dir/v8_context_snapshot.bin" ]

diff --git a/sandbox/BUILD.gn b/sandbox/BUILD.gn
@@ -53,7 +53,6 @@ buildflag_header("sandbox_buildflags") {
 fuzzer_test("sandbox_ipc_fuzzer") {
   set_sources_assignment_filter([])
   sources = [
-    "ipc.dict",
     "win/fuzzer/fuzzer_types.h",
     "win/fuzzer/sandbox_ipc_fuzzer.cc",
     "win/src/crosscall_server.cc",

diff --git a/third_party/blink/renderer/core/invisible_dom/BUILD.gn b/third_party/blink/renderer/core/invisible_dom/BUILD.gn
@@ -8,7 +8,6 @@ blink_core_sources("invisible_dom") {
   sources = [
     "activate_invisible_event.cc",
     "activate_invisible_event.h",
-    "activate_invisible_event.idl",
     "invisible_dom.cc",
     "invisible_dom.h",
   ]

diff --git a/third_party/blink/renderer/platform/BUILD.gn b/third_party/blink/renderer/platform/BUILD.gn
@@ -1407,8 +1407,10 @@ jumbo_component("platform") {
   sources += get_target_outputs(":character_data") +
              get_target_outputs(":color_data") +
              get_target_outputs(":font_family_names") +
-             get_target_outputs(":instrumentation_probes") +
-             get_target_outputs(":runtime_enabled_features")
+             get_target_outputs(":instrumentation_probes")
+  set_sources_assignment_filter([ "*.pickle" ])
+  sources += get_target_outputs(":runtime_enabled_features")
+  set_sources_assignment_filter(sources_assignment_filter)
 
   if (is_win) {
     jumbo_excluded_sources = [

diff --git a/third_party/crashpad/crashpad/snapshot/BUILD.gn b/third_party/crashpad/crashpad/snapshot/BUILD.gn
@@ -350,7 +350,6 @@ source_set("snapshot_test") {
       "crashpad_types/image_annotation_reader_test.cc",
       "elf/elf_image_reader_test.cc",
       "elf/elf_image_reader_test_note.S",
-      "elf/test_exported_symbols.sym",
     ]
   }
 

diff --git a/third_party/libxslt/BUILD.gn b/third_party/libxslt/BUILD.gn
@@ -68,7 +68,6 @@ static_library("libxslt") {
     "src/libxslt/xsltlocale.h",
     "src/libxslt/xsltutils.c",
     "src/libxslt/xsltutils.h",
-    "src/libxslt/xsltwin32config.h.in",
     "win32/config.h",
   ]
 

diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
@@ -460,7 +460,12 @@ template("grit") {
 
     # Since we generate a file, we need to be run before the targets that
     # depend on us.
+    set_sources_assignment_filter([
+                                    "*.json",
+                                    "*.pak",
+                                  ])
     sources = grit_outputs
+    set_sources_assignment_filter(sources_assignment_filter)
 
     # Deps set on the template invocation will go on the action that runs
     # grit above rather than this library. This target needs to depend on the