Skip to content

Commit

Permalink
Move the PR_GetCurrentThread suppression for worker threads to section
Browse files Browse the repository at this point in the history
2 because it is an expected leak.  Widen the suppression by eliding the
functions in the middle of the call stack.

R=thakis@chromium.org
BUG=32624
TEST=none

Review URL: http://codereview.chromium.org/7831016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99299 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
wtc@chromium.org committed Sep 2, 2011
1 parent 0740cfb commit 1a40e00
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions tools/valgrind/memcheck/suppressions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,23 @@
fun:PL_ArenaAllocate
fun:PORT_ArenaAlloc_Util
}
{
# PR_GetCurrentThread allocates a PRThread structure and stores it in
# thread-specific data. The PRThread structure is freed by the
# PR_DetachThread call in CertVerifierWorker::Run or when the thread
# terminates. Since we do not shut down worker threads, the PRThread
# structure created for a worker thread may be leaked at Chrome shutdown
# if the worker thread did not make it to the PR_DetachThread call.
bug_32624
Memcheck:Leak
fun:calloc
fun:PR_Calloc
fun:PR_GetCurrentThread
...
fun:_ZNK3net15X509Certificate14VerifyInternalERKSsiPNS_16CertVerifyResultE
fun:_ZNK3net15X509Certificate6VerifyERKSsiPNS_16CertVerifyResultE
fun:_ZN3net18CertVerifierWorker3RunEv
}
{
# Histograms are used on un-joined threads, and can't be deleted atexit.
Histograms via FactoryGet including Linear Custom Boolean and Basic
Expand Down Expand Up @@ -1908,23 +1925,6 @@
fun:_ZNK3net15X509Certificate6VerifyERKSsiPNS_16CertVerifyResultE
fun:_ZN3net18CertVerifierWorker3RunEv
}
{
bug_32624_f
Memcheck:Leak
fun:calloc
fun:PR_Calloc
fun:PR_GetCurrentThread
fun:PR_SetError
fun:PORT_SetError_Util
fun:cert_FindExtensionByOID
fun:cert_FindExtension
fun:CERT_FindCertExtension
fun:cert_VerifySubjectAltName
fun:CERT_VerifyCertName
fun:_ZNK3net15X509Certificate14VerifyInternalERKSsiPNS_16CertVerifyResultE
fun:_ZNK3net15X509Certificate6VerifyERKSsiPNS_16CertVerifyResultE
fun:_ZN3net18CertVerifierWorker3RunEv
}
{
bug_34554_a
Memcheck:Leak
Expand Down

0 comments on commit 1a40e00

Please sign in to comment.