Skip to content

Commit

Permalink
Remove inactive owners from /ash/keyboard
Browse files Browse the repository at this point in the history
Per discussion on the chromium-dev@ thread [1], we remove owners who made
0 commits / reviews to the Chromium repository in the past 12 months
(2021/7/26 - 2022/7/26).

For each owner removal, we upload a CL to remove the owner. The CL adds the
owner being removed and two other owners as reviewers. The CL will be
committed once it gets an LGTM from one of the reviewers.

Instructions:

- The guiding principle is: only owners who are meeting the owner's
expectations [2] should be written in OWNERS files. This is important to
ensure that developers can find active owners by looking at the OWNERS files.
- Please LGTM or not-LGTM the CL based on the removal guideline [3]. i.e.,
if the owner being removed was inactive only for a certain period of time
while they were on a long leave and has been meeting the owner's expectations
in other times, please not-LGTM the CL. Otherwise, please LGTM the CL.
- If the CL was LGTMed and landed by mistake (e.g., the reviewer was not aware
of the owner's leave status), we can just revert the CL.
- If you have any questions / comments, please send an explicit email to
haraken@chromium.org. (haraken@ is not watching all the comments of all the
removal CLs :-) If there is any disagreement between owners, it will be
escalated to Chrome Eng Review and resolved per [3].

[1] https://groups.google.com/a/chromium.org/g/chromium-dev/c/aGC8BTTFK64
[2] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#expectations-of-owners
[3] https://chromium.googlesource.com/chromium/src/+/main/docs/code_reviews.md#removal-of-owners

This CL was uploaded by git cl split.

R=bshe@chromium.org, rsadam@chromium.org, shend@chromium.org, shuchen@chromium.org, wuyingbing@chromium.org

Bug: 1355150
Change-Id: I42bc995538f7b138e47fa71501af78c9f1273fd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3843435
Auto-Submit: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1037811}
  • Loading branch information
xharaken authored and Chromium LUCI CQ committed Aug 22, 2022
1 parent 8f0f9f6 commit 199f95c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion ash/keyboard/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
shend@chromium.org
shuchen@chromium.org
wuyingbing@chromium.org
yhanada@chromium.org
2 changes: 0 additions & 2 deletions ash/keyboard/ui/resources/OWNERS

This file was deleted.

0 comments on commit 199f95c

Please sign in to comment.