Remove a few semicolons.

No behavior change. Bug: 926235 Change-Id: I731ae4f33079088d62b0748c99663fb9c5667fff Reviewed-on: https://chromium-review.googlesource.com/c/1458680 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#630025}
marcosholgado · Feb 7, 2019 · 199cd02 · 199cd02
1 parent 045e66e
commit 199cd02
Show file tree

Hide file tree

Showing 44 changed files with 93 additions and 96 deletions.
diff --git a/apps/ui/views/app_window_frame_view.h b/apps/ui/views/app_window_frame_view.h
@@ -59,9 +59,7 @@ class AppWindowFrameView : public views::NonClientFrameView,
   void SetResizeSizes(int resize_inside_bounds_size,
                       int resize_outside_bounds_size,
                       int resize_area_corner_size);
-  int resize_inside_bounds_size() const {
-    return resize_inside_bounds_size_;
-  };
+  int resize_inside_bounds_size() const { return resize_inside_bounds_size_; }
 
  private:
   // views::NonClientFrameView implementation.

diff --git a/cc/animation/element_animations.h b/cc/animation/element_animations.h
@@ -135,10 +135,10 @@ class CC_ANIMATION_EXPORT ElementAnimations
                                   KeyframeModel* keyframe_model) override;
   void NotifyClientSizeAnimated(const gfx::SizeF& size,
                                 int target_property_id,
-                                KeyframeModel* keyframe_model) override{};
+                                KeyframeModel* keyframe_model) override {}
   void NotifyClientColorAnimated(SkColor color,
                                  int target_property_id,
-                                 KeyframeModel* keyframe_model) override{};
+                                 KeyframeModel* keyframe_model) override {}
   void NotifyClientTransformOperationsAnimated(
       const TransformOperations& operations,
       int target_property_id,

diff --git a/cc/layers/painted_scrollbar_layer.cc b/cc/layers/painted_scrollbar_layer.cc
@@ -13,7 +13,7 @@
 
 namespace {
 static constexpr int kMaxScrollbarDimension = 8192;
-};
+}
 
 namespace cc {
 

diff --git a/cc/paint/paint_op_buffer.cc b/cc/paint/paint_op_buffer.cc
@@ -206,13 +206,13 @@ static bool g_has_paint_flags[kNumOpTypes] = {TYPES(M)};
 #define M(T)                                         \
   static_assert(sizeof(T) <= sizeof(LargestPaintOp), \
                 #T " must be no bigger than LargestPaintOp");
-TYPES(M);
+TYPES(M)
 #undef M
 
 #define M(T)                                               \
   static_assert(alignof(T) <= PaintOpBuffer::PaintOpAlign, \
                 #T " must have alignment no bigger than PaintOpAlign");
-TYPES(M);
+TYPES(M)
 #undef M
 
 using AnalyzeOpFunc = void (*)(PaintOpBuffer*, const PaintOp*);

diff --git a/cc/trees/image_animation_controller.h b/cc/trees/image_animation_controller.h
@@ -99,7 +99,7 @@ class CC_EXPORT ImageAnimationController {
   size_t GetFrameIndexForImage(PaintImage::Id paint_image_id,
                                WhichTree tree) const;
 
-  void set_did_navigate() { did_navigate_ = true; };
+  void set_did_navigate() { did_navigate_ = true; }
 
   const base::flat_set<AnimationDriver*>& GetDriversForTesting(
       PaintImage::Id paint_image_id) const;

diff --git a/chrome/browser/signin/chrome_signin_helper.h b/chrome/browser/signin/chrome_signin_helper.h
@@ -83,6 +83,6 @@ void ProcessAccountConsistencyResponseHeaders(ResponseAdapter* response,
                                               const GURL& redirect_url,
                                               bool is_off_the_record);
 
-};  // namespace signin
+}  // namespace signin
 
 #endif  // CHROME_BROWSER_SIGNIN_CHROME_SIGNIN_HELPER_H_
diff --git a/chrome/browser/ui/profile_chooser_constants.h b/chrome/browser/ui/profile_chooser_constants.h
@@ -27,6 +27,6 @@ enum BubbleViewMode {
   BUBBLE_VIEW_MODE_ACCOUNT_REMOVAL,
 };
 
-};  // namespace profiles
+}  // namespace profiles
 
 #endif  // CHROME_BROWSER_UI_PROFILE_CHOOSER_CONSTANTS_H_
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
@@ -17,7 +17,7 @@ namespace content {
 class NotificationDetails;
 class NotificationSource;
 class WebContents;
-};
+}  // namespace content
 
 // Base class for bubbles that are shown from location bar icons. The bubble
 // will automatically close when the browser transitions in or out of fullscreen

diff --git a/components/contextual_search/core/browser/contextual_search_preference.h b/components/contextual_search/core/browser/contextual_search_preference.h
@@ -36,7 +36,7 @@ bool IsEnabled(const PrefService& prefs);
 class ContextualSearchPreference {
  public:
   // No public constructor, use |GetInstance|.
-  ~ContextualSearchPreference(){};
+  ~ContextualSearchPreference() {}
 
   // Returns the singleton instance of this class, created when needed.
   static ContextualSearchPreference* GetInstance();

diff --git a/components/offline_pages/core/model/clear_digest_task.cc b/components/offline_pages/core/model/clear_digest_task.cc
@@ -31,7 +31,7 @@ ClearDigestTask::ClearDigestTask(OfflinePageMetadataStore* store,
   DCHECK(store_);
 }
 
-ClearDigestTask::~ClearDigestTask(){};
+ClearDigestTask::~ClearDigestTask() {}
 
 void ClearDigestTask::Run() {
   store_->Execute(base::BindOnce(&ClearDigestSync, offline_id_),

diff --git a/components/offline_pages/core/model/mark_page_accessed_task.cc b/components/offline_pages/core/model/mark_page_accessed_task.cc
@@ -82,7 +82,7 @@ MarkPageAccessedTask::MarkPageAccessedTask(OfflinePageMetadataStore* store,
   DCHECK(store_);
 }
 
-MarkPageAccessedTask::~MarkPageAccessedTask(){};
+MarkPageAccessedTask::~MarkPageAccessedTask() {}
 
 void MarkPageAccessedTask::Run() {
   store_->Execute(

diff --git a/components/offline_pages/core/model/update_file_path_task.cc b/components/offline_pages/core/model/update_file_path_task.cc
@@ -58,7 +58,7 @@ UpdateFilePathTask::UpdateFilePathTask(OfflinePageMetadataStore* store,
   DCHECK(store_);
 }
 
-UpdateFilePathTask::~UpdateFilePathTask(){};
+UpdateFilePathTask::~UpdateFilePathTask() {}
 
 void UpdateFilePathTask::Run() {
   store_->Execute(base::BindOnce(&UpdateFilePathSync, file_path_, offline_id_),

diff --git a/components/offline_pages/core/offline_page_client_policy.h b/components/offline_pages/core/offline_page_client_policy.h
@@ -105,7 +105,7 @@ struct OfflinePageClientPolicy {
       : name_space(namespace_val),
         lifetime_policy(lifetime_policy_val),
         pages_allowed_per_url(pages_allowed_per_url_val),
-        feature_policy(feature_policy_val){};
+        feature_policy(feature_policy_val) {}
 
   OfflinePageClientPolicy(std::string namespace_val,
                           LifetimePolicy lifetime_policy_val,

diff --git a/components/query_parser/query_parser.cc b/components/query_parser/query_parser.cc
@@ -72,7 +72,7 @@ class QueryNodeWord : public QueryNode {
 
   const base::string16& word() const { return word_; }
 
-  bool literal() const { return literal_; };
+  bool literal() const { return literal_; }
   void set_literal(bool literal) { literal_ = literal; }
 
   // QueryNode:

diff --git a/components/safe_browsing/db/v4_rice.cc b/components/safe_browsing/db/v4_rice.cc
@@ -273,7 +273,7 @@ uint32_t V4RiceDecoder::GetBitsFromCurrentWord(
   current_word_ = current_word_ >> num_requested_bits;
   current_word_bit_index_ += num_requested_bits;
   return x;
-};
+}
 
 std::string V4RiceDecoder::DebugString() const {
   // Calculates the total number of bits that we have read from the buffer,

diff --git a/components/translate/content/browser/content_translate_driver.h b/components/translate/content/browser/content_translate_driver.h
@@ -41,20 +41,20 @@ class ContentTranslateDriver : public TranslateDriver,
   class Observer {
    public:
     // Handles when the value of IsPageTranslated is changed.
-    virtual void OnIsPageTranslatedChanged(content::WebContents* source) {};
+    virtual void OnIsPageTranslatedChanged(content::WebContents* source) {}
 
     // Handles when the value of translate_enabled is changed.
-    virtual void OnTranslateEnabledChanged(content::WebContents* source) {};
+    virtual void OnTranslateEnabledChanged(content::WebContents* source) {}
 
     // Called when the page language has been determined.
     virtual void OnLanguageDetermined(
-        const translate::LanguageDetectionDetails& details) {};
+        const translate::LanguageDetectionDetails& details) {}
 
     // Called when the page has been translated.
-    virtual void OnPageTranslated(
-        const std::string& original_lang,
-        const std::string& translated_lang,
-        translate::TranslateErrors::Type error_type) {};
+    virtual void OnPageTranslated(const std::string& original_lang,
+                                  const std::string& translated_lang,
+                                  translate::TranslateErrors::Type error_type) {
+    }
 
    protected:
     virtual ~Observer() {}

diff --git a/components/translate/core/browser/translate_client.h b/components/translate/core/browser/translate_client.h
@@ -40,7 +40,7 @@ struct LanguageDetectionDetails;
 // TranslateManager is used (e.g. a single tab).
 class TranslateClient {
  public:
-  virtual ~TranslateClient() {};
+  virtual ~TranslateClient() {}
 
   // Gets the TranslateDriver associated with the client.
   virtual TranslateDriver* GetTranslateDriver() = 0;

diff --git a/content/browser/accessibility/one_shot_accessibility_tree_search.h b/content/browser/accessibility/one_shot_accessibility_tree_search.h
@@ -24,9 +24,9 @@ typedef bool (*AccessibilityMatchPredicate)(
     BrowserAccessibility* start_element,
     BrowserAccessibility* this_element);
 
-#define DECLARE_ACCESSIBILITY_PREDICATE(PredicateName) \
-    bool PredicateName(BrowserAccessibility* start_element, \
-                       BrowserAccessibility* this_element);
+#define DECLARE_ACCESSIBILITY_PREDICATE(PredicateName)    \
+  bool PredicateName(BrowserAccessibility* start_element, \
+                     BrowserAccessibility* this_element)
 
 DECLARE_ACCESSIBILITY_PREDICATE(AccessibilityArticlePredicate);
 DECLARE_ACCESSIBILITY_PREDICATE(AccessibilityBlockquotePredicate);

diff --git a/content/browser/appcache/appcache_url_request_job.h b/content/browser/appcache/appcache_url_request_job.h
@@ -18,7 +18,7 @@
 
 namespace net {
 class GrowableIOBuffer;
-};
+}
 
 namespace content {
 class AppCacheHost;

diff --git a/device/udev_linux/udev_watcher.cc b/device/udev_linux/udev_watcher.cc
@@ -48,7 +48,7 @@ std::unique_ptr<UdevWatcher> UdevWatcher::StartWatching(Observer* observer) {
 
 UdevWatcher::~UdevWatcher() {
   DCHECK(sequence_checker_.CalledOnValidSequence());
-};
+}
 
 void UdevWatcher::EnumerateExistingDevices() {
   DCHECK(sequence_checker_.CalledOnValidSequence());

diff --git a/gpu/command_buffer/client/gles2_interface.h b/gpu/command_buffer/client/gles2_interface.h
@@ -34,7 +34,7 @@ class GLES2Interface {
   GLES2Interface() = default;
   virtual ~GLES2Interface() = default;
 
-  virtual void FreeSharedMemory(void*) {};
+  virtual void FreeSharedMemory(void*) {}
 
   // Include the auto-generated part of this class. We split this because
   // it means we can easily edit the non-auto generated parts right here in

diff --git a/gpu/command_buffer/client/transfer_buffer.h b/gpu/command_buffer/client/transfer_buffer.h
@@ -284,7 +284,7 @@ class ScopedResultPtr {
     other.result_ = nullptr;
     other.transfer_buffer_ = nullptr;
     return *this;
-  };
+  }
 
   // Dereferencing behaviors
   T& operator*() const { return *result_; }

diff --git a/media/base/ipc/media_param_traits_macros.h b/media/base/ipc/media_param_traits_macros.h
@@ -118,17 +118,16 @@ IPC_ENUM_TRAITS_MAX_VALUE(media::OutputDeviceStatus,
                           media::OUTPUT_DEVICE_STATUS_MAX)
 
 IPC_ENUM_TRAITS_MAX_VALUE(media::PipelineStatus,
-                          media::PipelineStatus::PIPELINE_STATUS_MAX);
+                          media::PipelineStatus::PIPELINE_STATUS_MAX)
 
 IPC_ENUM_TRAITS_MAX_VALUE(media::SampleFormat, media::kSampleFormatMax)
 
 IPC_ENUM_TRAITS_MAX_VALUE(media::VideoCodec, media::kVideoCodecMax)
 
-IPC_ENUM_TRAITS_MAX_VALUE(media::WaitingReason,
-                          media::WaitingReason::kMaxValue);
+IPC_ENUM_TRAITS_MAX_VALUE(media::WaitingReason, media::WaitingReason::kMaxValue)
 
 IPC_ENUM_TRAITS_MAX_VALUE(media::WatchTimeKey,
-                          media::WatchTimeKey::kWatchTimeKeyMax);
+                          media::WatchTimeKey::kWatchTimeKeyMax)
 
 IPC_ENUM_TRAITS_MIN_MAX_VALUE(media::VideoCodecProfile,
                               media::VIDEO_CODEC_PROFILE_MIN,
@@ -139,7 +138,7 @@ IPC_ENUM_TRAITS_MAX_VALUE(media::VideoPixelFormat, media::PIXEL_FORMAT_MAX)
 IPC_ENUM_TRAITS_MAX_VALUE(media::VideoRotation, media::VIDEO_ROTATION_MAX)
 
 IPC_ENUM_TRAITS_MAX_VALUE(media::container_names::MediaContainerName,
-                          media::container_names::CONTAINER_MAX);
+                          media::container_names::CONTAINER_MAX)
 
 #if defined(OS_ANDROID)
 IPC_ENUM_TRAITS_MIN_MAX_VALUE(media::MediaDrmKeyType,
@@ -151,19 +150,19 @@ IPC_ENUM_TRAITS_VALIDATE(
     media::VideoColorSpace::PrimaryID,
     static_cast<int>(value) ==
         static_cast<int>(
-            media::VideoColorSpace::GetPrimaryID(static_cast<int>(value))));
+            media::VideoColorSpace::GetPrimaryID(static_cast<int>(value))))
 
 IPC_ENUM_TRAITS_VALIDATE(
     media::VideoColorSpace::TransferID,
     static_cast<int>(value) ==
         static_cast<int>(
-            media::VideoColorSpace::GetTransferID(static_cast<int>(value))));
+            media::VideoColorSpace::GetTransferID(static_cast<int>(value))))
 
 IPC_ENUM_TRAITS_VALIDATE(
     media::VideoColorSpace::MatrixID,
     static_cast<int>(value) ==
         static_cast<int>(
-            media::VideoColorSpace::GetMatrixID(static_cast<int>(value))));
+            media::VideoColorSpace::GetMatrixID(static_cast<int>(value))))
 
 // Struct traits.
 

diff --git a/media/base/key_systems.h b/media/base/key_systems.h
@@ -76,7 +76,7 @@ class MEDIA_EXPORT KeySystems {
       const std::string& key_system) const = 0;
 
  protected:
-  virtual ~KeySystems() {};
+  virtual ~KeySystems() {}
 };
 
 // TODO(ddorwin): WebContentDecryptionModuleSessionImpl::initializeNewSession()

diff --git a/media/filters/ffmpeg_bitstream_converter.h b/media/filters/ffmpeg_bitstream_converter.h
@@ -14,7 +14,7 @@ namespace media {
 // Interface for classes that allow reformating of FFmpeg bitstreams
 class MEDIA_EXPORT FFmpegBitstreamConverter {
  public:
-  virtual ~FFmpegBitstreamConverter() {};
+  virtual ~FFmpegBitstreamConverter() {}
 
   // Reads the data in packet, and then overwrites this data with the
   // converted version of packet

diff --git a/media/formats/mp4/box_definitions.h b/media/formats/mp4/box_definitions.h
@@ -39,7 +39,7 @@ enum SampleFlags {
   T(const T& other);                      \
   ~T() override;                          \
   bool Parse(BoxReader* reader) override; \
-  FourCC BoxType() const override;
+  FourCC BoxType() const override
 
 struct MEDIA_EXPORT FileType : Box {
   DECLARE_BOX_METHODS(FileType);

diff --git a/media/midi/midi_manager_alsa.h b/media/midi/midi_manager_alsa.h
@@ -212,7 +212,7 @@ class MIDI_EXPORT MidiManagerAlsa final : public MidiManager {
    public:
     iterator erase(iterator position) {
       return MidiPortStateBase::erase(position);
-    };
+    }
     void push_back(std::unique_ptr<MidiPort> port) {
       MidiPortStateBase::push_back(std::move(port));
     }
@@ -359,7 +359,7 @@ class MIDI_EXPORT MidiManagerAlsa final : public MidiManager {
   struct SndMidiEventDeleter {
     void operator()(snd_midi_event_t* coder) const {
       snd_midi_event_free(coder);
-    };
+    }
   };
 
   using SourceMap = std::unordered_map<int, uint32_t>;

diff --git a/media/midi/task_service.h b/media/midi/task_service.h
@@ -104,6 +104,6 @@ class MIDI_EXPORT TaskService final {
   DISALLOW_COPY_AND_ASSIGN(TaskService);
 };
 
-};  // namespace midi
+}  // namespace midi
 
 #endif  // MEDIA_MIDI_TASK_SERVICE_H_
diff --git a/media/video/picture.h b/media/video/picture.h
@@ -112,7 +112,7 @@ class MEDIA_EXPORT Picture {
   // without requesting new PictureBuffers. GpuVideoDecoder should read this
   // as a signal to update the size of the corresponding PicutreBuffer using
   // visible_rect() upon receiving this Picture from a VDA.
-  bool size_changed() const { return size_changed_; };
+  bool size_changed() const { return size_changed_; }
 
   void set_size_changed(bool size_changed) { size_changed_ = size_changed; }
 

diff --git a/net/base/registry_controlled_domains/registry_controlled_domain.h b/net/base/registry_controlled_domains/registry_controlled_domain.h
@@ -125,7 +125,7 @@ class GURL;
 
 namespace url {
 class Origin;
-};
+}
 
 struct DomainRule;
 

diff --git a/ppapi/proxy/interface_list.h b/ppapi/proxy/interface_list.h
@@ -63,7 +63,7 @@ class PPAPI_PROXY_EXPORT InterfaceList {
     // Permission required to return non-null for this interface. This will
     // be checked with the value set via SetProcessGlobalPermissionBits when
     // an interface is requested.
-    Permission required_permission() { return required_permission_; };
+    Permission required_permission() { return required_permission_; }
 
     // Call this any time the interface is requested. It will log a UMA count
     // only the first time. This is safe to call from any thread, regardless of

diff --git a/services/media_session/public/cpp/test/mock_media_session.h b/services/media_session/public/cpp/test/mock_media_session.h
@@ -101,7 +101,7 @@ class COMPONENT_EXPORT(MEDIA_SESSION_TEST_SUPPORT_CPP) MockMediaSession
   void GetDebugInfo(GetDebugInfoCallback callback) override;
   void PreviousTrack() override;
   void NextTrack() override;
-  void SkipAd() override{};
+  void SkipAd() override {}
   void Seek(base::TimeDelta seek_time) override;
   void Stop(SuspendType type) override;
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,7 @@ @@
     namespace {
     static constexpr int kMaxScrollbarDimension = 8192;
-    };
+    }
     namespace cc {
@@ Expand Down @@