Skip to content

Commit

Permalink
[iOS] Ensure correct tab grid mode for search scrim test.
Browse files Browse the repository at this point in the history
testScrimVisibleInSearchModeWhenSearchBarIsEmpty was disabled due to
flake. Images of the test state for these failures showed the tab grid
on the recent tabs panel; successful test runs are on the normal tabs
panel.

This CL adds a step to move to the regular tabs panel at the start of
the test.

Fixed: 1359271
Change-Id: I69f0ec2ffc56c86efad84ef68be3c5f17714a2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3925616
Auto-Submit: Mark Cogan <marq@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1052886}
  • Loading branch information
marcq authored and Chromium LUCI CQ committed Sep 29, 2022
1 parent 2e08988 commit 0fb4de8
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1434,11 +1434,14 @@ - (void)testTabGridResetAfterExitingSearch {

// Tests that the scrim view is always shown when the search bar is empty in the
// search mode.
// TODO(crbug.com/1359271): Disabled due to flakiness. Re-enabled when fixed.
- (void)DISABLED_testScrimVisibleInSearchModeWhenSearchBarIsEmpty {
- (void)testScrimVisibleInSearchModeWhenSearchBarIsEmpty {
[ChromeEarlGrey openNewTab];
[ChromeEarlGreyUI openTabGrid];

// Make sure the tab grid is on the regular tabs panel.
[[EarlGrey selectElementWithMatcher:TabGridNormalModePageControl()]
performAction:grey_tap()];

// Enter search mode.
[[EarlGrey selectElementWithMatcher:TabGridSearchTabsButton()]
performAction:grey_tap()];
Expand Down

0 comments on commit 0fb4de8

Please sign in to comment.