Skip to content

Commit

Permalink
Remove unused ScreenOrientation IPC message.
Browse files Browse the repository at this point in the history
Also moves an IPC_ENUM_TRAITS definition to where it's actually used
now: it just happened to work before, since the IPC message generation
headers happen to #include things in mostly alphabetical order.

BUG=none

Review URL: https://codereview.chromium.org/1131263007

Cr-Commit-Position: refs/heads/master@{#329182}
  • Loading branch information
zetafunction authored and Commit bot committed May 11, 2015
1 parent 2694744 commit 0b68593
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
10 changes: 0 additions & 10 deletions content/common/screen_orientation_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,12 @@
#include "ipc/ipc_message_macros.h"
#include "third_party/WebKit/public/platform/WebLockOrientationError.h"
#include "third_party/WebKit/public/platform/WebScreenOrientationLockType.h"
#include "third_party/WebKit/public/platform/WebScreenOrientationType.h"

#undef IPC_MESSAGE_EXPORT
#define IPC_MESSAGE_EXPORT CONTENT_EXPORT

#define IPC_MESSAGE_START ScreenOrientationMsgStart

IPC_ENUM_TRAITS_MIN_MAX_VALUE(blink::WebScreenOrientationType,
blink::WebScreenOrientationUndefined,
blink::WebScreenOrientationLandscapeSecondary)
IPC_ENUM_TRAITS_MIN_MAX_VALUE(blink::WebScreenOrientationLockType,
blink::WebScreenOrientationLockDefault,
blink::WebScreenOrientationLockNatural)
Expand All @@ -27,12 +23,6 @@ IPC_ENUM_TRAITS_MIN_MAX_VALUE(
blink::WebLockOrientationErrorNotAvailable,
blink::WebLockOrientationErrorCanceled)

// The browser process informs the renderer process that the screen orientation
// has changed. |orientation| contains the new screen orientation in degrees.
// TODO(mlamouri): we could probably get rid of it.
IPC_MESSAGE_CONTROL1(ScreenOrientationMsg_OrientationChange,
blink::WebScreenOrientationType /* orientation */ )

// The browser process' response to a ScreenOrientationHostMsg_LockRequest when
// the lock actually succeeded. The |request_id| passed when receiving the
// request is passed back so the renderer process can associate the response to
Expand Down
5 changes: 5 additions & 0 deletions content/common/view_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include "third_party/WebKit/public/platform/WebFloatPoint.h"
#include "third_party/WebKit/public/platform/WebFloatRect.h"
#include "third_party/WebKit/public/platform/WebScreenInfo.h"
#include "third_party/WebKit/public/platform/WebScreenOrientationType.h"
#include "third_party/WebKit/public/web/WebDeviceEmulationParams.h"
#include "third_party/WebKit/public/web/WebFindOptions.h"
#include "third_party/WebKit/public/web/WebMediaPlayerAction.h"
Expand Down Expand Up @@ -82,6 +83,10 @@ IPC_ENUM_TRAITS_MAX_VALUE(blink::WebPluginAction::Type,
blink::WebPluginAction::Type::TypeLast)
IPC_ENUM_TRAITS_MAX_VALUE(blink::WebPopupType,
blink::WebPopupType::WebPopupTypeLast)
// TODO(dcheng): Update WebScreenOrientationType to have a "Last" enum member.
IPC_ENUM_TRAITS_MIN_MAX_VALUE(blink::WebScreenOrientationType,
blink::WebScreenOrientationUndefined,
blink::WebScreenOrientationLandscapeSecondary)
IPC_ENUM_TRAITS_MAX_VALUE(blink::WebTextDirection,
blink::WebTextDirection::WebTextDirectionLast)
IPC_ENUM_TRAITS_MAX_VALUE(blink::WebDisplayMode,
Expand Down

0 comments on commit 0b68593

Please sign in to comment.