Skip to content

Commit

Permalink
Revert of Add missing dependencies on exe_and_shlib_deps (Chromium re…
Browse files Browse the repository at this point in the history
…po) (patchset chromium#2 id:60001 of https://codereview.chromium.org/2899403004/ )

Reason for revert:
BUG=726808

Suspecting causing generate_build_files failure (according to FindIt)

Original issue's description:
> Add missing dependencies on exe_and_shlib_deps (Chromium repo)
>
> BUG=723069
> R=brettw@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng
>
> Review-Url: https://codereview.chromium.org/2899403004
> Cr-Commit-Position: refs/heads/master@{#475059}
> Committed: https://chromium.googlesource.com/chromium/src/+/9e926233bf660c42676d6bd4cb77dade846aca69

TBR=brettw@chromium.org,davidben@chromium.org,thomasanderson@google.com,thomasanderson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=723069

Review-Url: https://codereview.chromium.org/2912513002
Cr-Commit-Position: refs/heads/master@{#475077}
  • Loading branch information
nedn authored and Commit bot committed May 26, 2017
1 parent 2771709 commit 0503f51
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 15 deletions.
1 change: 0 additions & 1 deletion components/url_formatter/top_domains/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ if (!is_ios && !is_android) {
deps = [
"//base",
"//base:i18n",
"//build/config:exe_and_shlib_deps",
"//third_party/icu",
]
}
Expand Down
1 change: 0 additions & 1 deletion gpu/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ shared_library("command_buffer_gles2") {
deps = [
":gpu",
"//base",
"//build/config:exe_and_shlib_deps",
"//gpu/command_buffer/client:gles2_c_lib",
"//gpu/command_buffer/client:gles2_implementation",
"//gpu/command_buffer/common:gles2_utils",
Expand Down
2 changes: 0 additions & 2 deletions headless/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,6 @@ executable("headless_shell") {

deps = [
":headless_shell_lib",
"//build/config:exe_and_shlib_deps",
]

if (is_win) {
Expand All @@ -716,6 +715,5 @@ executable("headless_example") {

deps = [
":headless_shell_lib",
"//build/config:exe_and_shlib_deps",
]
}
3 changes: 0 additions & 3 deletions media/cast/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ if (is_win || is_mac || (is_linux && !is_chromeos)) {
":receiver",
":test_support",
"//base",
"//build/config:exe_and_shlib_deps",
"//build/win:default_exe_manifest",
"//media",
"//media/audio:test_support",
Expand Down Expand Up @@ -441,7 +440,6 @@ if (is_win || is_mac || (is_linux && !is_chromeos)) {
":sender",
":test_support",
"//base",
"//build/config:exe_and_shlib_deps",
"//build/win:default_exe_manifest",
"//media",
]
Expand All @@ -468,7 +466,6 @@ if (is_win || is_mac || (is_linux && !is_chromeos)) {
":test_support",
"//base",
"//base/test:test_support",
"//build/config:exe_and_shlib_deps",
"//build/win:default_exe_manifest",
"//media",
"//media/base:test_support",
Expand Down
1 change: 0 additions & 1 deletion media/cdm/ppapi/ppapi_cdm_adapter.gni
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ template("ppapi_cdm_adapter") {

defines += [ "USE_PPAPI_CDM_ADAPTER" ]
deps += [
"//build/config:exe_and_shlib_deps",
"//media:cdm_api",
"//ppapi/cpp",
]
Expand Down
2 changes: 0 additions & 2 deletions net/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2914,7 +2914,6 @@ if (is_linux || is_mac) {
":net",
":test_support",
"//base",
"//build/config:exe_and_shlib_deps",
]
}

Expand All @@ -2929,7 +2928,6 @@ if (is_linux || is_mac) {
":net",
":test_support",
"//base",
"//build/config:exe_and_shlib_deps",
"//url",
]
}
Expand Down
2 changes: 1 addition & 1 deletion ppapi/examples/ppapi_example.gni
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ template("ppapi_example") {
}

sources = invoker.sources
deps = invoker.deps + [ "//build/config:exe_and_shlib_deps" ]
deps = invoker.deps
}
} else {
mac_plugin_bundle(target_name) {
Expand Down
3 changes: 1 addition & 2 deletions remoting/host/linux/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ source_set("x11") {
]
}

executable("remoting_native_messaging_host") {
target("executable", "remoting_native_messaging_host") {
configs += [ "//build/config/compiler:wexit_time_destructors" ]

sources = [
Expand All @@ -101,7 +101,6 @@ executable("remoting_native_messaging_host") {

deps = [
"//base",
"//build/config:exe_and_shlib_deps",
"//net",
"//remoting/base:breakpad",
"//remoting/host",
Expand Down
1 change: 0 additions & 1 deletion remoting/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ if (enable_remoting_host && !is_android && !is_chromeos) {

deps = [
":it2me_standalone_host",
"//build/config:exe_and_shlib_deps",
]

if (is_desktop_linux) {
Expand Down
1 change: 0 additions & 1 deletion third_party/leveldatabase/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ if (!is_ios && !is_android) {
configs += [ "//build/config/compiler:no_chromium_code" ]
deps = [
":leveldatabase",
"//build/config:exe_and_shlib_deps",
]
}

Expand Down

0 comments on commit 0503f51

Please sign in to comment.