Skip to content

Commit

Permalink
Revert "Android: Remove last remnants of ANT"
Browse files Browse the repository at this point in the history
This reverts commit 38636aa.

Reason for revert: downstream failure: unable to find chromium-debug.keystore (internal bug: http://crbug.com/776328)

Original change's description:
> Android: Remove last remnants of ANT
> 
> It had a good run.
> 
> Bug: 375324
> Change-Id: I1db1d501f58d3d3ac8731bc36e8ca550da24adf9
> Reviewed-on: https://chromium-review.googlesource.com/722521
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509785}

TBR=thakis@chromium.org,agrieve@chromium.org

Change-Id: I7323c95dcdd47145166d6bbd61345cc17db2e7d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 375324
Reviewed-on: https://chromium-review.googlesource.com/727902
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510056}
  • Loading branch information
pasko authored and Commit Bot committed Oct 19, 2017
1 parent 26c1f21 commit 0462fc4
Show file tree
Hide file tree
Showing 8 changed files with 139 additions and 3 deletions.
125 changes: 125 additions & 0 deletions build/android/ant/apk-package.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (C) 2005-2008 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

<project default="-package">
<property name="verbose" value="false" />
<property name="out.dir" location="${OUT_DIR}" />
<property name="out.absolute.dir" location="${out.dir}" />

<property name="sdk.dir" location="${ANDROID_SDK_ROOT}"/>
<property name="emma.device.jar" location="${EMMA_DEVICE_JAR}" />

<condition property="emma.enabled" value="true" else="false">
<equals arg1="${EMMA_INSTRUMENT}" arg2="1"/>
</condition>

<!-- jar file from where the tasks are loaded -->
<path id="android.antlibs">
<pathelement path="${sdk.dir}/tools/lib/ant-tasks.jar" />
</path>

<!-- Custom tasks -->
<taskdef resource="anttasks.properties" classpathref="android.antlibs" />

<condition property="build.target" value="release" else="debug">
<equals arg1="${CONFIGURATION_NAME}" arg2="Release" />
</condition>
<condition property="build.is.packaging.debug" value="true" else="false">
<equals arg1="${build.target}" arg2="debug" />
</condition>

<!-- Disables automatic signing. -->
<property name="build.is.signing.debug" value="false"/>

<!-- SDK tools assume that out.packaged.file is signed and name it "...-unaligned" -->
<property name="out.packaged.file" value="${UNSIGNED_APK_PATH}" />

<property name="native.libs.absolute.dir" location="${NATIVE_LIBS_DIR}" />

<!-- Intermediate files -->
<property name="resource.package.file.name" value="${RESOURCE_PACKAGED_APK_NAME}" />

<property name="intermediate.dex.file" location="${DEX_FILE_PATH}" />
<condition property="multidex.enabled" value="true">
<equals arg1="${MULTIDEX_ENABLED}" arg2="1"/>
</condition>

<!-- Macro that enables passing a variable list of external jar files
to ApkBuilder. -->
<macrodef name="package-helper">
<element name="extra-jars" optional="yes" />
<sequential>
<apkbuilder
outfolder="${out.absolute.dir}"
resourcefile="${resource.package.file.name}"
apkfilepath="${out.packaged.file}"
debugpackaging="${build.is.packaging.debug}"
debugsigning="${build.is.signing.debug}"
verbose="${verbose}"
hascode="${HAS_CODE}"
previousBuildType="/"
buildType="${build.is.packaging.debug}/${build.is.signing.debug}">
<dex path="${intermediate.dex.file}" />
<nativefolder path="${native.libs.absolute.dir}" />
<extra-jars/>
</apkbuilder>
</sequential>
</macrodef>

<macrodef name="multidex-package-helper">
<element name="extra-jars" optional="yes" />
<sequential>
<apkbuilder
outfolder="${out.absolute.dir}"
resourcefile="${resource.package.file.name}"
apkfilepath="${out.packaged.file}"
debugpackaging="${build.is.packaging.debug}"
debugsigning="${build.is.signing.debug}"
verbose="${verbose}"
hascode="false"
previousBuildType="/"
buildType="${build.is.packaging.debug}/${build.is.signing.debug}">
<zip path="${intermediate.dex.file}" />
<nativefolder path="${native.libs.absolute.dir}" />
<extra-jars/>
</apkbuilder>
</sequential>
</macrodef>

<!-- Packages the application. -->
<target name="-package">
<if condition="${emma.enabled}">
<then>
<package-helper>
<extra-jars>
<jarfile path="${emma.device.jar}" />
</extra-jars>
</package-helper>
</then>
<else>
<if condition="${multidex.enabled}">
<then>
<multidex-package-helper />
</then>
<else>
<package-helper />
</else>
</if>
</else>
</if>
</target>
</project>
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions build/android/empty/src/.keep
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
This is a file that needs to live here until http://crbug.com/158155 has
been fixed.

The ant build system requires that a src folder is always present, and for
some of our targets that is not the case. Giving it an empty src-folder works
nicely though.
3 changes: 2 additions & 1 deletion build/config/android/config.gni
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ if (is_android) {
}

if (!defined(default_android_keystore_path)) {
default_android_keystore_path = "//build/android/chromium-debug.keystore"
default_android_keystore_path =
"//build/android/ant/chromium-debug.keystore"
default_android_keystore_name = "chromiumdebugkey"
default_android_keystore_password = "chromium"
}
Expand Down
2 changes: 1 addition & 1 deletion build/config/android/internal_rules.gni
Original file line number Diff line number Diff line change
Expand Up @@ -2803,7 +2803,7 @@ if (enable_java_templates) {
_all_resource_dirs += invoker.resource_dirs

# Speed up "gn gen" by short-circuiting the empty directory.
if (invoker.resource_dirs != [ "//build/android/empty" ] &&
if (invoker.resource_dirs != [ "//build/android/ant/empty/res" ] &&
invoker.resource_dirs != []) {
_sources_build_rel =
exec_script("//build/android/gyp/find.py",
Expand Down
2 changes: 1 addition & 1 deletion build/config/android/rules.gni
Original file line number Diff line number Diff line change
Expand Up @@ -2044,7 +2044,7 @@ if (enable_java_templates) {
srcjar_path = "${target_gen_dir}/${target_name}.srcjar"
r_text_out_path = "${target_gen_dir}/${target_name}_R.txt"
android_manifest = _android_manifest
resource_dirs = [ "//build/android/empty" ]
resource_dirs = [ "//build/android/ant/empty/res" ]
zip_path = resources_zip_path
all_resources_zip_path = _all_resources_zip_path
generate_constant_ids = true
Expand Down
4 changes: 4 additions & 0 deletions build/install-build-deps-android.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ sudo apt-get -y install lib32z1 lighttpd python-pexpect xvfb x11-utils
# See https://developer.android.com/sdk/installing/index.html?pkg=tools
sudo apt-get -y install libncurses5:i386 libstdc++6:i386 zlib1g:i386

# Required by //components/cronet/tools/generate_javadoc.py
# TODO(375324): Stop requiring ANT.
sudo apt-get -y install ant

# Required for apk-patch-size-estimator
sudo apt-get -y install bsdiff

Expand Down

0 comments on commit 0462fc4

Please sign in to comment.