Skip to content

Commit

Permalink
Revert 198736 "Land Recent QUIC changes"
Browse files Browse the repository at this point in the history
Caused compile failures on the "Google Chrome ChromeOS" builder:
cc1plus: warnings being treated as errors
net/quic/quic_utils.cc:14:error: integer constant is too large for 'unsigned long' type
net/quic/quic_utils.cc:15:error: integer constant is too large for 'unsigned long' type
make: *** [out/Release/obj.target/net/net/quic/quic_utils.o] Error 1


> Land Recent QUIC changes
> 
> Implement header compression/decompression in ReliableQuicStream.
> 
> Merge internal change: 44867738
> 
> 
> QUIC: deflake proof_test.
> 
> The current proof_test removes a byte from the start of the signature in order
> to make it invalid. However, the signature is a big-endian number and, ~1% of
> the time, the first byte will be zero - thus removing it doesn't change the
> number.
> 
> This change adds a non-zero byte to the start of the signature instead.
> 
> Merge internal change: 44803399
> 
> Replace calls to scoped_ptr(NULL) with calls to scoped_ptr().
> 
> Merge internal change: 44799980
> 
> Add a blank line in order to get the dependencies correct for rebuild.
> 
> Merge internal change: 44796024
> 
> Fix "large integer implicitly truncated to unsigned type"
> 
> Merge internal change: 44793986
> 
> QUIC: compress certificates.
> 
> This change causes server certificates to be compressed using three tricks:
>   1) The client can advertise sets of common certificates that the server can
>      then simply reference. This change contains "common certificate set 0",
>      which is the set of the intermediates used twice or more in the Alexa top
>      5000. It's temporary because it's missing GIAG2 which we'll want to
>      include soon.
>   2) The client can send 64-bit, FNV-1a hashes of certificates that it already
>      has and the server can reference them by hash.
>   3) Otherwise, certifciates are gzip compressed with a dictionary that
>      includes any certificates compressed using the previous two methods and a
>      1500 byte lump of common substrings. (Again, taken from the Alexa top 5000)
> 
> POKE=1
> 
> Merge internal change: 44792710
> 
> R=rch@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/14651009

TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/15018013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198764 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
csharp@chromium.org committed May 7, 2013
1 parent 9686bb3 commit 0439abf
Show file tree
Hide file tree
Showing 54 changed files with 138 additions and 23,899 deletions.
3 changes: 0 additions & 3 deletions android_webview/tools/third_party_files_whitelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ content/browser/renderer_host/web_input_event_aurax11.cc
# Copyright Google Inc, no license. Not used on Android.
google_update/google_update_idl.idl
# String '(c)' used in certificates organization names
net/quic/crypto/common_cert_set_1_50.inc
net/quic/crypto/common_cert_set_51_100.inc
# String '(c)' used in certificates organization names
net/test/test_certificate_data.h
# Copyright The Chromium Authors and Netscape Communications Corporation; BSD
# and (MPL, GPL v2 or LGPL v2) licenses. This third-party code is taken from
Expand Down
18 changes: 0 additions & 18 deletions net/base/iovec.h

This file was deleted.

16 changes: 0 additions & 16 deletions net/net.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@
'base/host_port_pair.h',
'base/io_buffer.cc',
'base/io_buffer.h',
'base/iovec.h',
'base/ip_endpoint.cc',
'base/ip_endpoint.h',
'base/keygen_handler.cc',
Expand Down Expand Up @@ -712,10 +711,6 @@
'quic/crypto/aes_128_gcm_encrypter.h',
'quic/crypto/aes_128_gcm_encrypter_nss.cc',
'quic/crypto/aes_128_gcm_encrypter_openssl.cc',
'quic/crypto/cert_compressor.cc',
'quic/crypto/cert_compressor.h',
'quic/crypto/common_cert_set.cc',
'quic/crypto/common_cert_set.h',
'quic/crypto/crypto_framer.cc',
'quic/crypto/crypto_framer.h',
'quic/crypto/crypto_handshake.cc',
Expand Down Expand Up @@ -793,10 +788,6 @@
'quic/quic_reliable_client_stream.h',
'quic/quic_session.cc',
'quic/quic_session.h',
'quic/quic_spdy_compressor.cc',
'quic/quic_spdy_compressor.h',
'quic/quic_spdy_decompressor.cc',
'quic/quic_spdy_decompressor.h',
'quic/quic_stats.cc',
'quic/quic_stats.h',
'quic/quic_stream_factory.cc',
Expand All @@ -809,8 +800,6 @@
'quic/quic_utils.h',
'quic/reliable_quic_stream.cc',
'quic/reliable_quic_stream.h',
'quic/spdy_utils.cc',
'quic/spdy_utils.h',
'socket/buffered_write_stream_socket.cc',
'socket/buffered_write_stream_socket.h',
'socket/client_socket_factory.cc',
Expand Down Expand Up @@ -1638,15 +1627,12 @@
'quic/congestion_control/tcp_receiver_test.cc',
'quic/crypto/aes_128_gcm_decrypter_test.cc',
'quic/crypto/aes_128_gcm_encrypter_test.cc',
'quic/crypto/cert_compressor_test.cc',
'quic/crypto/common_cert_set_test.cc',
'quic/crypto/crypto_framer_test.cc',
'quic/crypto/crypto_handshake_test.cc',
'quic/crypto/curve25519_key_exchange_test.cc',
'quic/crypto/null_decrypter_test.cc',
'quic/crypto/null_encrypter_test.cc',
'quic/crypto/p256_key_exchange_test.cc',
'quic/crypto/proof_test.cc',
'quic/crypto/quic_random_test.cc',
'quic/crypto/strike_register_test.cc',
'quic/test_tools/crypto_test_utils.cc',
Expand Down Expand Up @@ -1694,8 +1680,6 @@
'quic/quic_protocol_test.cc',
'quic/quic_reliable_client_stream_test.cc',
'quic/quic_session_test.cc',
'quic/quic_spdy_compressor_test.cc',
'quic/quic_spdy_decompressor_test.cc',
'quic/quic_stream_factory_test.cc',
'quic/quic_stream_sequencer_test.cc',
'quic/quic_time_test.cc',
Expand Down
Loading

0 comments on commit 0439abf

Please sign in to comment.