Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Fix conditions for can_unwind_with_cfi_table with frame point…
…ers" This reverts commit e34f08f. Reason for revert: using_sanitizer should also set enable_frame_pointer on android. The cfi bot was broken because it enabled cfi unwinding with frame pointers. Original change's description: > Revert "Fix conditions for can_unwind_with_cfi_table with frame pointers" > > This reverts commit 5e4c7d7. > > Reason for revert: > Speculative revert for failing base_unittests on Android, > CFIBacktraceAndroidTest.TestUnwinding. > > See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Android%20CFI/builds/579 > > Original change's description: > > Fix conditions for can_unwind_with_cfi_table with frame pointers > > > > CFI table unwinder is not appilcable for builds with frame pointer > > enabled. Make sure can_unwind_with_cfi_table is set to false. > > No need to check for use_thin_lto. > > > > BUG=469376 > > > > Change-Id: I71a4de08a0496edf26829c69851ea89bdbc02bd6 > > Reviewed-on: https://chromium-review.googlesource.com/992890 > > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#548634} > > TBR=thakis@chromium.org,ssid@chromium.org,pcc@chromium.org > > Change-Id: I1bb99a9cde8fd501bd5abb7aa7fe798684454226 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 469376,826718 > Reviewed-on: https://chromium-review.googlesource.com/999635 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548765} Change-Id: Ic6637dfe890a51264f9d151a681534fe92fc9354 Bug: 469376, 826718 Reviewed-on: https://chromium-review.googlesource.com/1000412 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#553287}
- Loading branch information