Skip to content

Commit

Permalink
Fetch tools/perf/process_perf_results.py onto orchestrator builds
Browse files Browse the repository at this point in the history
Orchestrator builds mostly run without a checkout. So any scripts needed
to merge/collect test results need to be fetched from the child
compilator builds. This GN target encapsulates that. And it currently
lacks the script tools/perf/process_perf_results.py. This is making
views_perftests' collect stage fail:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8806375136850553825/+/u/views_perftests__with_patch__on_Ubuntu-18.04/Merge_script_log

So adding that script to the files fetched onto the orchestrator
should fix that.

Needs crrev.com/c/3821797 before this can land.

Bug: 1346781
Change-Id: I8f75a035383f9cd0197bdca89136448a1b9752f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3817976
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1033654}
  • Loading branch information
bpastene authored and Chromium LUCI CQ committed Aug 10, 2022
1 parent 2b82557 commit 028104a
Show file tree
Hide file tree
Showing 3 changed files with 711 additions and 0 deletions.
1 change: 1 addition & 0 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -1214,6 +1214,7 @@ class BanRule:
'third_party/blink/tools/merge_web_test_results.pydeps',
'tools/binary_size/sizes.pydeps',
'tools/binary_size/supersize.pydeps',
'tools/perf/process_perf_results.pydeps',
]


Expand Down
5 changes: 5 additions & 0 deletions infra/orchestrator/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ group("orchestrator_all") {
# profile information
":code_coverage_merge_results_py",
":code_coverage_merge_steps_py",
":process_perf_results_py",
":standard_gtest_merge_py",
":standard_isolated_script_merge_py",
]
Expand Down Expand Up @@ -71,3 +72,7 @@ python_library("code_coverage_merge_results_py") {
python_library("code_coverage_merge_steps_py") {
pydeps_file = "//testing/merge_scripts/code_coverage/merge_steps.pydeps"
}

python_library("process_perf_results_py") {
pydeps_file = "//tools/perf/process_perf_results.pydeps"
}
Loading

0 comments on commit 028104a

Please sign in to comment.