Skip to content

Commit

Permalink
refactor(ext/streams): remove fake detached (denoland#16431)
Browse files Browse the repository at this point in the history
Removed "fake detached" logic since it's no longer needed after
[denoland#16294](denoland#16294) landed
  • Loading branch information
marcosc90 authored Oct 26, 2022
1 parent 6ac603e commit de580ce
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions ext/web/06_streams.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,20 +187,12 @@
);
}

const isFakeDetached = Symbol("<<detached>>");

/**
* @param {ArrayBufferLike} O
* @returns {boolean}
*/
function isDetachedBuffer(O) {
if (O.byteLength !== 0) {
return false;
}
// TODO(marcosc90) remove isFakeDetached once transferArrayBuffer
// actually detaches the buffer
return ReflectHas(O, isFakeDetached) ||
core.ops.op_arraybuffer_was_detached(O);
return O.byteLength === 0 && ops.op_arraybuffer_was_detached(O);
}

/**
Expand All @@ -225,9 +217,7 @@
* @returns {ArrayBufferLike}
*/
function transferArrayBuffer(O) {
const v = ops.op_transfer_arraybuffer(O);
O[isFakeDetached] = true;
return v;
return ops.op_transfer_arraybuffer(O);
}

/**
Expand Down

0 comments on commit de580ce

Please sign in to comment.