refactor(ext/fetch): avoid extra headers copy in .clone (denoland#16130)

marcosc90 · Oct 3, 2022 · d13c88e · d13c88e
1 parent 7a77672
commit d13c88e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/ext/fetch/23_request.js b/ext/fetch/23_request.js
@@ -35,7 +35,6 @@
     ObjectKeys,
     ObjectPrototypeIsPrototypeOf,
     RegExpPrototypeTest,
-    SafeArrayIterator,
     Symbol,
     SymbolFor,
     TypeError,
@@ -159,11 +158,11 @@
    * @returns {InnerRequest}
    */
   function cloneInnerRequest(request) {
-    const headerList = [
-      ...new SafeArrayIterator(
-        ArrayPrototypeMap(request.headerList, (x) => [x[0], x[1]]),
-      ),
-    ];
+    const headerList = ArrayPrototypeMap(
+      request.headerList,
+      (x) => [x[0], x[1]],
+    );
+
     let body = null;
     if (request.body !== null) {
       body = request.body.clone();

diff --git a/ext/fetch/23_response.js b/ext/fetch/23_response.js
@@ -97,11 +97,11 @@
    */
   function cloneInnerResponse(response) {
     const urlList = [...new SafeArrayIterator(response.urlList)];
-    const headerList = [
-      ...new SafeArrayIterator(
-        ArrayPrototypeMap(response.headerList, (x) => [x[0], x[1]]),
-      ),
-    ];
+    const headerList = ArrayPrototypeMap(
+      response.headerList,
+      (x) => [x[0], x[1]],
+    );
+
     let body = null;
     if (response.body !== null) {
       body = response.body.clone();