Linter: Implement erb-closing-tag-indent rule#1445
Open
markokajzer wants to merge 1 commit intomarcoroth:mainfrom
Open
Linter: Implement erb-closing-tag-indent rule#1445markokajzer wants to merge 1 commit intomarcoroth:mainfrom
erb-closing-tag-indent rule#1445markokajzer wants to merge 1 commit intomarcoroth:mainfrom
Conversation
github-actions
bot
added
documentation
markokajzer
changed the title
erb-closing-tag-indent ruleerb-closing-tag-indent rule
markokajzer
force-pushed
the
marko/closingtagindent
branch
6 times, most recently
from
fcc9099 to
e79f27c
Compare
markokajzer
force-pushed
the
marko/closingtagindent
branch
from
e79f27c to
510233b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #555
Linter Rule: Enforce consistent closing ERB tag indentation
Rule:
erb-closing-tag-indentDescription
This rule enforces that the closing ERB tag (
%>) is consistently indented relative to its opening tag (<%or<%=). When an ERB tag spans multiple lines, the closing%>must be on its own line and indented to match the column position of the opening tag.Rationale
Inconsistent indentation of closing ERB tags makes templates harder to read and maintain. When an ERB tag spans multiple lines, the closing
%>should visually align with the opening<%to clearly show the tag boundaries. Conversely, if the opening tag is on the same line as the content, the closing tag should also be on the same line.