Update assembly.py

[smoothumut]

when a mesh is added , then it crashes. it needs vtkOpenGLActor instead of vedo.mesh. so a.actor solves the problem

[coderabbitai]

Walkthrough

The recent updates to the vedo/assembly.py file enhance error handling within the __iadd__ method. By introducing a try-except block around the addition process, the method can now attempt to add a.actor if adding a fails. This improvement increases the robustness of the assembly feature, ensuring graceful management of various input types and minimizing potential interruptions in functionality.

Changes

Files	Change Summary
vedo/assembly.py	Enhanced error handling in __iadd__ by adding a try-except block to manage part addition failures.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Assembly
    participant Part

    User->>Assembly: __iadd__(a)
    activate Assembly
    Assembly->>Assembly: try to AddPart(a)
    alt Success
        Assembly-->>User: Part added successfully
    else Failure
        Assembly->>Assembly: try to AddPart(a.actor)
        alt Success
            Assembly-->>User: Actor part added successfully
        else Failure
            Assembly-->>User: Failed to add part
        end
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b91c52e and 3c8608c.

Files selected for processing (1)

• vedo/assembly.py (1 hunks)

Additional context used

Ruff

vedo/assembly.py

140-140: Do not use bare except

(E722)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3c8608c and ff97d65.

Files selected for processing (1)

• vedo/assembly.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• vedo/assembly.py

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ff97d65 and 95a646e.

Files selected for processing (1)

• vedo/assembly.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• vedo/assembly.py

[marcomusy]

Thanks Umut!