Prevent merging close vertices when converting to Trimesh #1160
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
vedo/utils.py (1)
2474-2474: Issue Found: Function calls tovedo2trimeshdo not handle the newprocessparameterThe code changes introduce a new
processparameter in thevedo2trimeshfunction, but the existing function calls do not pass this parameter.
- File:
vedo/utils.py
- Line: 2474
- Issue: The call to
vedo2trimeshdoes not pass theprocessparameter.Please update all calls to
vedo2trimeshto handle the newprocessparameter correctly.Analysis chain
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
vedo2trimeshare updated to handle the newprocessparameter correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `vedo2trimesh` are updated to handle the new `process` parameter. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type python -A 5 $'vedo2trimesh'Length of output: 67
Script:
#!/bin/bash # Description: Verify all function calls to `vedo2trimesh` are updated to handle the new `process` parameter. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg -t py -A 5 'vedo2trimesh'Length of output: 679
Script:
#!/bin/bash # Description: Gather more context around the function calls to `vedo2trimesh` to verify the handling of the `process` parameter. # Test: Search for the function usage with more context. Expect: Detailed occurrences of the function calls. rg -t py -A 10 'vedo2trimesh'Length of output: 1089
|
Thanks! |
Calling vedo2trimesh() can result in the loss of vertices, as initializing a Trimesh mesh merges close vertices by default (with a tolerance of 1e-8).
Adding
process=Falseprevents this and ensures that the converted mesh does not get altered.