Use relative paths for the grammar input files #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file paths that are passed to antlr end up in the generated output so using absolute paths breaks caching. Fixes marcohu#12.
This was referenced Sep 28, 2024
|
@rrbutani FYI this has ben partially merged at albertocavalcante#30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file paths that are passed to ANTLR end up in the generated output so using absolute paths breaks caching.
This PR makes it so that the relative paths to the grammar files that we get from Bazel are passed straight through to ANTLR.
To keep ANTLR from trying to recreate the directory structure containing the grammar files within the output directory I had to add
-Xexact-output-dirfor ANTLR4 and-fofor ANTLR3. ANTLR2 doesn't seem to have an equivalent flag and doesn't seem to have the same behavior for relative grammar file input paths.Fixes #12.