Skip to content

Commit

Permalink
Bug 1566598 [wpt PR 17863] - Expose kv-storage built-in module only o…
Browse files Browse the repository at this point in the history
…n SecureContexts, a=testonly

Automatic update from web-platform-tests
Expose kv-storage built-in module only on SecureContexts

This CL adds actual restriction in Blink implementation.

This CL also modifies tests and expectations to match with
the current Blink built-in/import maps infra.

A subtest in WPT test `import-statement.html` is failing
because the current Blink implementation is based on
pre-import-map spec and thus
importing unavailable built-in causes fetch error.
See 'import 'std:nonexistent';' row of
WICG/import-maps#159.

Bug: 977470
Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Kouhei Ueno <kouheichromium.org>
Cr-Commit-Position: refs/heads/master{#691821}

--

wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb
wpt-pr: 17863

UltraBlame original commit: c1d0da7bf6a9c3b42d025aaedd5f352b6fd1345a
  • Loading branch information
marco-c committed Oct 4, 2019
1 parent 9d43eb4 commit 93ec1ac
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,15 @@
:
{
"
std
:
kv
.
/
resources
/
dummy
-
storage
module
.
js
"
:
[
Expand Down Expand Up @@ -184,17 +188,21 @@
import
(
"
std
:
kv
.
/
resources
/
dummy
-
storage
module
.
js
"
)
;
assert_equals
(
namespaceObj
result
.
myExport
"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,25 @@
"
)
;
async_test
(
const
t
=
>
{
async_test
(
'
Static
import
kv
-
storage
in
non
-
secure
context
'
)
;
window
.
addEventListener
Expand Down Expand Up @@ -167,9 +180,6 @@
)
)
;
}
)
;
<
/
script
Expand All @@ -181,6 +191,26 @@
"
module
"
onerror
=
"
t
.
unreached_func
(
'
script
error
event
should
not
be
fired
'
)
(
)
"
>
import
"
Expand Down

0 comments on commit 93ec1ac

Please sign in to comment.