Skip to content

Commit

Permalink
Bug 1835021 [wpt PR 40218] - [scroll-animations] Avoid scroll/view-ti…
Browse files Browse the repository at this point in the history
…meline-attachment in WPTs, a=testonly

Automatic update from web-platform-tests
[scroll-animations] Avoid scroll/view-timeline-attachment in WPTs

These properties will be removed from the spec [1]. The new property
timeline-scope offers similar functionality.

This CL is mostly a self-explanatory migration from
*-timeline-attachment to timeline-scope, with a few exceptions:

 - The test id=timeline_ancestor_scroll_timeline_wins_on_same_element
   needed more severe adjustment, because deferred timelines are
   no longer typed (that is, a deferred timeline is not a
   scroll timeline nor a view timeline), so that test had
   to be refactored to avoid using deferred timelines.
 - A few tests in view-timeline-dynamic.html were refactored to avoid
   timeline-scope, as timeline-scope was not essential for those tests.

[1] w3c/csswg-drafts#7759

Bug: 1446702
Change-Id: I205069b065a97928f755993f3c5f301693cc72ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4565315
Reviewed-by: Mustaq Ahmed <mustaqchromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org>
Cr-Commit-Position: refs/heads/main{#1149088}

--

wpt-commits: 3b4953ad7022f11d7e756404bd0c34a059431993
wpt-pr: 40218

UltraBlame original commit: cb8731f862c32ac8e42e2c845710f56523047d72
  • Loading branch information
marco-c committed Jun 16, 2023
1 parent f8ee823 commit 4a453c4
Show file tree
Hide file tree
Showing 17 changed files with 83 additions and 8,879 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,9 @@
:
0px
;
scroll
-
timeline
-
attachment
:
defer
;
scroll
-
timeline
-
name
scope
:
-
-
Expand Down Expand Up @@ -138,14 +128,6 @@
:
100px
;
scroll
-
timeline
-
attachment
:
ancestor
;
}
.
scroller
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,9 @@
>
main
{
scroll
-
timeline
-
attachment
:
defer
;
scroll
-
timeline
-
name
scope
:
-
-
Expand Down Expand Up @@ -149,14 +139,6 @@
:
100px
;
scroll
-
timeline
-
attachment
:
ancestor
;
}
.
scroller
Expand Down
Loading

0 comments on commit 4a453c4

Please sign in to comment.