-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1528828 [wpt PR 15449] - [css-tables] Add some subpixel collapsed…
… border tests, a=testonly Automatic update from web-platform-tests [css-tables] Add some subpixel collapsed border tests This CL contains tests only, no behavior change. Chrome passes only 001, no matter the device pixels. Safari-lodpi and Firefox-lodpi pass only 001 and 002. EdgeHTML 18.17763-lodpi, Firefox-hidpi, and Safari-hidpi pass 001, 002, and 003. From a plain reading of the tables spec the 003 test is correct. But given its rampant failure (only EdgeHTML passes when 1x device pixel per CSS pixel), it'd be reasonable to codify the current empirical behavior somewhere, if it's not already in a place that I missed. Chrome probably passes 001 but fails 002 because of LayoutUnit's 1/64 pixel precision but that's not confirmed. Note that these tests will become invalid if the proposal in w3c/csswg-drafts#606 is adopted. Bug: 377847 Change-Id: Ifc9e8f9f878f7462cb949670350eadb17c7c2940 Reviewed-on: https://chromium-review.googlesource.com/c/1477334 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Reviewed-by: David Grogan <dgroganchromium.org> Commit-Queue: David Grogan <dgroganchromium.org> Cr-Commit-Position: refs/heads/master{#633538} -- wpt-commits: 41a8506f54e688d655e662f59584dcbf777990f2 wpt-pr: 15449 UltraBlame original commit: 3a39e45af185cdada307e0e2b4d161928d980817
- Loading branch information
Showing
5 changed files
with
134 additions
and
0 deletions.
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-001.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!DOCTYPE html> | ||
| <link rel="author" title="David Grogan" href="mailto:dgrogan@chromium.org"> | ||
| <link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm"> | ||
| <link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606"> | ||
| <link rel="match" href="subpixel-collapsed-borders-ref.html"> | ||
| <meta name="flags" content="" /> | ||
| <meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins." /> | ||
|
|
||
| <style> | ||
| table { | ||
| border: 5px solid green; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| td { | ||
| width: 50px; | ||
| height: 50px; | ||
| border: 4.95px solid red; | ||
| } | ||
| </style> | ||
|
|
||
| <p>There should be a square with a green border, not a red border. | ||
| </p> | ||
|
|
||
| <table> | ||
| <tr> | ||
| <td></td> | ||
| </tr> | ||
| </table> |
30 changes: 30 additions & 0 deletions
30
testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-002.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!DOCTYPE html> | ||
| <link rel="author" title="David Grogan" href="mailto:dgrogan@chromium.org"> | ||
| <link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm"> | ||
| <link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606"> | ||
| <link rel="match" href="subpixel-collapsed-borders-ref.html"> | ||
| <meta name="flags" content="" /> | ||
| <meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins even when the cell border is merely 0.01 pixels narrower" /> | ||
|
|
||
| <style> | ||
| table { | ||
| border: 5px solid green; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| td { | ||
| width: 50px; | ||
| height: 50px; | ||
| border: 4.99px solid red; | ||
| } | ||
| </style> | ||
|
|
||
| <p>There should be a square with a green border, not a red border. | ||
| </p> | ||
|
|
||
| <table> | ||
| <tr> | ||
| <td></td> | ||
| </tr> | ||
| </table> |
22 changes: 22 additions & 0 deletions
22
testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-003-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <!DOCTYPE html> | ||
| <style> | ||
| table { | ||
| border: 5.95px solid green; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| td { | ||
| width: 50px; | ||
| height: 50px; | ||
| border: 1px solid red; | ||
| } | ||
| </style> | ||
|
|
||
| <p>There should be a square with a green border, not a red border. | ||
| </p> | ||
|
|
||
| <table> | ||
| <tr> | ||
| <td></td> | ||
| </tr> | ||
| </table> |
30 changes: 30 additions & 0 deletions
30
testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-003.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!DOCTYPE html> | ||
| <link rel="author" title="David Grogan" href="mailto:dgrogan@chromium.org"> | ||
| <link rel="help" href="https://www.w3.org/TR/CSS22/tables.html#collapsing-borders"> | ||
| <link rel="help" href="https://drafts.csswg.org/css-tables-3/#border-conflict-resolution-algorithm"> | ||
| <link rel="help" href="https://github.com/w3c/csswg-drafts/issues/606"> | ||
| <link rel="match" href="subpixel-collapsed-borders-003-ref.html"> | ||
| <meta name="flags" content="" /> | ||
| <meta name="assert" content="When collapsed border tables have border widths larger than cells', the table border wins even when the floored table border is the same size as the cell's." /> | ||
|
|
||
| <style> | ||
| table { | ||
| border: 5.95px solid green; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| td { | ||
| width: 50px; | ||
| height: 50px; | ||
| border: 5px solid red; | ||
| } | ||
| </style> | ||
|
|
||
| <p>There should be a square with a green border, not a red border. | ||
| </p> | ||
|
|
||
| <table> | ||
| <tr> | ||
| <td></td> | ||
| </tr> | ||
| </table> |
22 changes: 22 additions & 0 deletions
22
testing/web-platform/tests/css/css-tables/subpixel-collapsed-borders-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <!DOCTYPE html> | ||
| <style> | ||
| table { | ||
| border: 5px solid green; | ||
| border-collapse: collapse; | ||
| } | ||
|
|
||
| td { | ||
| width: 50px; | ||
| height: 50px; | ||
| border: 1px solid red; | ||
| } | ||
| </style> | ||
|
|
||
| <p>There should be a square with a green border, not a red border. | ||
| </p> | ||
|
|
||
| <table> | ||
| <tr> | ||
| <td></td> | ||
| </tr> | ||
| </table> |