Removed dirty checking, minor optimizations #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update will now only be queued through requestAnimationFrame whenever changes occurred. This means that absolutely no code is running when the page is idling (helpful for power saving and scalability). Care was taken to first read from the DOM and afterwards update it in the new scroll handler to prevent any possible layout thrashing as described here: http://wilsonpage.co.uk/preventing-layout-thrashing/ lastWidth, lastHeight and all sensor properties are only updated once every frame.
An element may change its size multiple times during a frame. Do not emit events anymore if its size returned to its previous size since the last update. This means that events occurring in between two frames - which are never visible to the user - may be skipped.
Sensors need to be reset even if the element's size returned to its original dimensions.
Resetting within the requestAnimationFrame handler lead to bad performance. This was noticeable in the performance demo where this version fares about as good as older versions.
Closed
|
Nice addition, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update will now only be queued through requestAnimationFrame whenever
changes occurred. This means that absolutely no code is running when the
page is idling (helpful for power saving and scalability). Care was
taken to first read from the DOM and afterwards update it in the new
scroll handler to prevent any possible layout thrashing as described here:
http://wilsonpage.co.uk/preventing-layout-thrashing/
lastWidth, lastHeight and all sensor properties are only updated
once every frame.