Conversation
- Add missing `aria-label` attributes to email, password, name, and phone inputs. - Fix custom checkbox keyboard accessibility by making the input `sr-only peer` instead of `hidden`. - Add `peer-focus-visible` classes to visually indicate focus on custom checkboxes during keyboard navigation. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Improved the accessibility of the
AuthModalcomponent by addingaria-labels to inputs that only relied on placeholder text, and fixing custom checkboxes so they are navigable by keyboard.🎯 Why:
aria-labels, as placeholder text often disappears and isn't reliably announced.display: none) checkbox inputs cannot receive focus, preventing keyboard and screen reader users from interacting with or navigating to the consent checkboxes. By using thesr-onlyandpeerTailwind classes, the native checkbox remains focusable without disrupting the UI, and the visual checkbox ring provides a clear focus indicator.♿ Accessibility:
aria-label="Adres E-mail",aria-label="Hasło",aria-label="Imię (opcjonalnie)", andaria-label="Nr telefonu (opcjonalnie)".hiddentosr-only peer.peer-focus-visible:ring-2 peer-focus-visible:ring-[#0055ff] peer-focus-visible:ring-offset-2to custom checkbox visuals.PR created automatically by Jules for task 2227544374976327432 started by @marcin2121