🔒 fix: Secure admin server actions by enforcing role checks#14
🔒 fix: Secure admin server actions by enforcing role checks#14marcin2121 wants to merge 1 commit intomainfrom
Conversation
- Removed `SUPABASE_SERVICE_ROLE_KEY` fallback to `NEXT_PUBLIC_SUPABASE_ANON_KEY` - Added check for `app_metadata.role === 'admin'` before allowing the action - Used `createServerClient` to authenticate the current user correctly Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The vulnerability fixed
The server actions
getAdminUsersDetailsandgetAdminUserCouponsinapp/actions/get-admin-users.tswere completely unprotected. They bypassed Row-Level Security (RLS) and did not verify the caller's identity or role. Even worse, if the service role key was missing, it defaulted to the anonymous key.Any user, authenticated or not, could potentially invoke these server actions. This would allow an attacker to bypass RLS and read the entire list of users or read any user's private coupons from the database. This constitutes a severe Broken Access Control vulnerability.
🛡️ Solution: How the fix addresses the vulnerability
SUPABASE_SERVICE_ROLE_KEYtoNEXT_PUBLIC_SUPABASE_ANON_KEY. If the admin key is missing, the action fails cleanly.createServerClient) to fetch the current active session.user.app_metadata?.role === 'admin'exists before executing the privilegedsupabaseAdmincode. This matches the security standard used in the middleware and guarantees that only verified administrators can call these functions.PR created automatically by Jules for task 12529834210628468742 started by @marcin2121